GitHub actions: update to current versions by neteler · Pull Request #847 · OSGeo/grass-addons

neteler · 2023-01-18T11:06:58Z

The GHA ci.yml and others show the warning

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2, r-lib/actions/setup-r@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Additionally:

update the various actions
updates ubuntu-20.04 to ubuntu-22.04 (see also CI: switch to ubuntu-22.04 image to avoid timeout grass#2730)
sync Python to v3.10
updates to super-linter:v4
super-linter: enable markdown linting
use the real super-linter action instead of a container
super-linter.yml: do not mix VALIDATE=true and VALIDATE=false

The GHA `ci.yml` and others show the warning _Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2, r-lib/actions/setup-r@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/._ This PR - updates the various actions - syncs Python to v3.10

.github/workflows/flake8.yml

.github/workflows/super-linter.yml

Co-authored-by: Nicklas Larsson <[email protected]>

neteler · 2023-01-18T13:16:47Z

The Super-linter is yet unhappy, ideas?

2023-01-18 12:55:17 [INFO]   Gathering user validation information...
2023-01-18 12:55:17 [INFO]   - Validating ALL files in code base...
2023-01-18 12:55:17 [FATAL]   Behavior not supported, please either only include (VALIDATE=true) or exclude (VALIDATE=false) linters, but not both

nilason · 2023-01-18T13:30:32Z

Did a quick look at https://github.com/github/super-linter, but haven't been able to pinpoint exactly what needs to be changed yet.

GRASS core is still using super-linter:v2.2.2:

https://github.com/OSGeo/grass/blob/cb8293e8d40c02857b3a15bac441f703339ba5fd/.github/workflows/super-linter.yml#L22

nilason · 2023-01-18T13:34:12Z

Perhaps upgrading super-linter could be subject for a separate PR. The other changes looks good to me.

echoix

For the lines under,

          VALIDATE_BASH: false
          VALIDATE_CSS: false
          VALIDATE_DOCKER: false
          VALIDATE_JAVASCRIPT_ES: true
          VALIDATE_JAVASCRIPT_STANDARD: false
          VALIDATE_JSON: true
          VALIDATE_MD: true
          VALIDATE_PERL: false
          VALIDATE_POWERSHELL: true
          VALIDATE_XML: false
          VALIDATE_YAML: true

If I remember well super-linter, once either one linter is enabled or disabled, it won't run all the linters by default. You must manually list all the ones you want activated if you include one VALIDATE_<a language>: true.
Edit: see https://github.com/marketplace/actions/super-linter#environment-variables, which tells the same thing

So, if only the ones you want to run are the ones that are true currently true, we can comment out the false ones:

          # VALIDATE_BASH: false
          # VALIDATE_CSS: false
          # VALIDATE_DOCKER: false
          VALIDATE_JAVASCRIPT_ES: true
          # VALIDATE_JAVASCRIPT_STANDARD: false
          VALIDATE_JSON: true
          VALIDATE_MD: true
          # VALIDATE_PERL: false
          VALIDATE_POWERSHELL: true
          # VALIDATE_XML: false
          VALIDATE_YAML: true

I don't think disabling Docker is still useful though, we do have some Dockerfiles.

.github/workflows/super-linter.yml

nilason · 2023-01-18T13:39:35Z

So, if only the ones you want to run are the ones that are true currently true, we can comment out the false ones:

          # VALIDATE_BASH: false
          # VALIDATE_CSS: false
          # VALIDATE_DOCKER: false
          VALIDATE_JAVASCRIPT_ES: true
          # VALIDATE_JAVASCRIPT_STANDARD: false
          VALIDATE_JSON: true
          VALIDATE_MD: true
          # VALIDATE_PERL: false
          VALIDATE_POWERSHELL: true
          # VALIDATE_XML: false
          VALIDATE_YAML: true

Worth a try!

I don't think disabling Docker is still useful though, we do have some Dockerfiles.

In "addons"?

echoix · 2023-01-18T13:42:00Z

In "addons"?

Oh, I forgot that it was this repo.

Co-authored-by: Edouard Choinière <[email protected]>

neteler · 2023-01-18T18:16:53Z

Thanks for your suggestions.
I have now commented out the entries set to false super-linter.yml (cb87c31).
If that fails, too, I'll go back to the original superlinter version (then updates may go into a separate PR).

neteler · 2023-01-18T19:35:23Z

So, if only the ones you want to run are the ones that are true currently true, we can comment out the false ones

Thanks @echoix, your super-linter.yml change suggestion worked!

nilason

Nice!

.github/workflows/super-linter.yml

Co-authored-by: Nicklas Larsson <[email protected]>

neteler · 2023-01-23T19:38:28Z

This now fails with markdown errors :D (so, the runner works).

nilason · 2023-01-24T11:23:09Z

This now fails with markdown errors :D (so, the runner works).

I'm working on a linting fix for markdown files...

* CI: update github/super-linter docker tag to v4 Replaces #2778 Selectively update `super-linter.yml` to GRASS GIS Addons PR OSGeo/grass-addons#847 * do not mix VALIDATE=true and VALIDATE=false * VALIDATE_MD -> VALIDATE_MARKDOWN Co-authored-by: Nicklas Larsson <[email protected]>

* CI: update github/super-linter docker tag to v4 Replaces OSGeo#2778 Selectively update `super-linter.yml` to GRASS GIS Addons PR OSGeo/grass-addons#847 * do not mix VALIDATE=true and VALIDATE=false * VALIDATE_MD -> VALIDATE_MARKDOWN Co-authored-by: Nicklas Larsson <[email protected]>

* GitHub actions: update to current versions The GHA `ci.yml` and others show the warning _Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2, r-lib/actions/setup-r@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/._ Additionally: - update the various actions - updates ubuntu-20.04 to ubuntu-22.04 (see also OSGeo/grass#2730) - sync Python to v3.10 - updates to super-linter:v4 - super-linter: enable markdown linting - use the real super-linter action instead of a container - super-linter.yml: do not mix VALIDATE=true and VALIDATE=false Co-authored-by: Nicklas Larsson <[email protected]> Co-authored-by: Edouard Choinière <[email protected]>

* CI: update github/super-linter docker tag to v4 Replaces OSGeo#2778 Selectively update `super-linter.yml` to GRASS GIS Addons PR OSGeo/grass-addons#847 * do not mix VALIDATE=true and VALIDATE=false * VALIDATE_MD -> VALIDATE_MARKDOWN Co-authored-by: Nicklas Larsson <[email protected]>

neteler added the CI Continuous integration label Jan 18, 2023

neteler self-assigned this Jan 18, 2023

nilason reviewed Jan 18, 2023

View reviewed changes

.github/workflows/flake8.yml Outdated Show resolved Hide resolved

nilason reviewed Jan 18, 2023

View reviewed changes

.github/workflows/super-linter.yml Outdated Show resolved Hide resolved

neteler and others added 2 commits January 18, 2023 13:35

quote version

65f42ab

Co-authored-by: Nicklas Larsson <[email protected]>

fix super-linter error

92a584e

Co-authored-by: Nicklas Larsson <[email protected]>

echoix reviewed Jan 18, 2023

View reviewed changes

.github/workflows/super-linter.yml Outdated Show resolved Hide resolved

neteler and others added 2 commits January 18, 2023 19:12

use the real super-linter action instead of a container

8daca06

Co-authored-by: Edouard Choinière <[email protected]>

super-linter.yml: comment out entries set to false

cb87c31

neteler requested review from nilason and wenzeslaus January 18, 2023 19:33

nilason approved these changes Jan 18, 2023

View reviewed changes

neteler mentioned this pull request Jan 23, 2023

CI: update github/super-linter docker tag to v4 OSGeo/grass#2782

Merged

nilason reviewed Jan 23, 2023

View reviewed changes

.github/workflows/super-linter.yml Outdated Show resolved Hide resolved

neteler and others added 2 commits January 23, 2023 19:54

VALIDATE_MD -> VALIDATE_MARKDOWN

3911a49

Co-authored-by: Nicklas Larsson <[email protected]>

do not mix VALIDATE=true and VALIDATE=false

e3c49db

neteler merged commit eb67fa0 into OSGeo:grass8 Jan 24, 2023

neteler deleted the gh_actions_update branch January 24, 2023 11:09

Comments

Conversation

neteler commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neteler commented Jan 18, 2023

Uh oh!

nilason commented Jan 18, 2023

Uh oh!

nilason commented Jan 18, 2023

Uh oh!

echoix left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nilason commented Jan 18, 2023

Uh oh!

echoix commented Jan 18, 2023

Uh oh!

neteler commented Jan 18, 2023

Uh oh!

neteler commented Jan 18, 2023

Uh oh!

nilason left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

neteler commented Jan 23, 2023

Uh oh!

nilason commented Jan 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

neteler commented Jan 18, 2023 •

edited

Loading

echoix left a comment •

edited

Loading