Skip to content

Comments

i.sentinel: easier computing shadows#137

Merged
neteler merged 12 commits intoOSGeo:masterfrom
anikaweinmann:i.sentinel_easier_shadows
Apr 6, 2020
Merged

i.sentinel: easier computing shadows#137
neteler merged 12 commits intoOSGeo:masterfrom
anikaweinmann:i.sentinel_easier_shadows

Conversation

@anikaweinmann
Copy link
Contributor

i.sentinel.mask needs the MTD_TL.xml file. The used information are also written by i.sentinel.import with r.support in the metadata of the bands.
Since, the metadata cannot be parsed properly due to wrong line breaks, you can now create a json dump metadata file by i.sentinel.import and use it in i.sentinel.mask.

@neteler neteler requested a review from RobiFag April 2, 2020 12:05
@ninsbl
Copy link
Member

ninsbl commented Apr 2, 2020

FYI: I do have a (not yet committed) raster based computation of cloud shadows (derived from this module) that can speedup the process significantly, esp. for higher cloud coverage with many cloud areas...
Will try to get a test version out ASAP.

@neteler
Copy link
Member

neteler commented Apr 6, 2020

@AnikaBettge please let me know when you think it is ready for merge,

@anikaweinmann
Copy link
Contributor Author

@neteler I think it is now ready for merge

Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@neteler neteler merged commit 3d2cca9 into OSGeo:master Apr 6, 2020
@veroandreo
Copy link
Contributor

This is a great improvement and I know this is merged already, but how are we supposed to easily know the name of the json dump to use it as input for i.sentinel.mask? Do we need to browse in the mapset files or does it get printed when i.sentinel.import finishes? An extra example for this use case would be highly appreciated and would also make the improvement more visible and discoverable by users

landam pushed a commit to landam/grass-addons that referenced this pull request Dec 10, 2020
* add metadata json dump file for shadow computing
* Update grass7/imagery/i.sentinel/i.sentinel.mask/i.sentinel.mask.py
* write same number of files -j and metadata
* change standard json folder to cell_misc/RASTERNAME

Co-authored-by: Markus Neteler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants