Skip to content

Comments

cronjob: fix old stable build (G83)#1168

Merged
neteler merged 4 commits intoOSGeo:grass8from
neteler:cron_fix_old_stable_build
Aug 13, 2024
Merged

cronjob: fix old stable build (G83)#1168
neteler merged 4 commits intoOSGeo:grass8from
neteler:cron_fix_old_stable_build

Conversation

@neteler
Copy link
Member

@neteler neteler commented Aug 12, 2024

Fix build error which broke the G83 cronjob prior to inject the "go-to-new-version" notification box.

Injects 'G8.x is the new version' box, separately for landing page and addon pages due to different HTML structure.

Also:

  • inject canonical URL metadata only there still needed
  • minor comment wording fixes.

Will fix:

to look like shown below:

image

addons:

image

Fix build error which broke the cronjob prior to inject the "go-to-new-version" notification box.

Also minor comment wording fixes.
@neteler neteler added bug Something isn't working CI Continuous integration labels Aug 12, 2024
@neteler neteler self-assigned this Aug 12, 2024
@neteler neteler requested a review from veroandreo August 13, 2024 07:54
@veroandreo
Copy link
Contributor

@neteler, if you tested and it looks fine, I trust. I cannot really judge the change in the scripts.

I guess it also fixes what I see now, no?

  • In individual addon pages the box is duplicated
    image

  • and in core 83 tools, it does not appear
    image

@neteler
Copy link
Member Author

neteler commented Aug 13, 2024

  • In individual addon pages the box is duplicated

Mhh, I don't see that?
https://grass.osgeo.org/grass83/manuals/addons/

@neteler
Copy link
Member Author

neteler commented Aug 13, 2024

  • and in core 83 tools, it does not appear

Sure, because this PR isn't merged yet :)

@neteler neteler closed this Aug 13, 2024
@neteler neteler reopened this Aug 13, 2024
@neteler
Copy link
Member Author

neteler commented Aug 13, 2024

  • In individual addon pages the box is duplicated

I fixed now a dupe for G78 addons.

@neteler
Copy link
Member Author

neteler commented Aug 13, 2024

As soon as the minimal CI is done I'll merge. Then we'll see how it behaves in the next days.

@neteler neteler merged commit 35090bc into OSGeo:grass8 Aug 13, 2024
@neteler neteler deleted the cron_fix_old_stable_build branch August 13, 2024 13:43
neteler added a commit to neteler/grass-website that referenced this pull request Nov 27, 2024
So far https://grass.osgeo.org/sitemap.xml showed the versioned manual pages which is unhelpful in terms of consolidating search engine results for manuals.
In the past months we were penalized by "duplicate content".

For an overview, see OSGeo/grass#4579

For efforts to address this situation, see

- OSGeo/grass-addons#1168
- OSGeo/grass-addons#1241

This PR changes the URL in `sitemap.xml` from versioned manual URLs to grass-stable/grass-devel in order to complete the other PRs.
neteler added a commit to OSGeo/grass-website that referenced this pull request Nov 27, 2024
So far https://grass.osgeo.org/sitemap.xml showed the versioned manual pages which is unhelpful in terms of consolidating search engine results for manuals.
In the past months we were penalized by "duplicate content".

For an overview, see OSGeo/grass#4579

For efforts to address this situation, see

- OSGeo/grass-addons#1168
- OSGeo/grass-addons#1241

This PR changes the URL in `sitemap.xml` from versioned manual URLs to grass-stable/grass-devel in order to complete the other PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI Continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants