docker: build GUI from ubuntu using build-args#6800
Merged
echoix merged 9 commits intoOSGeo:mainfrom Dec 22, 2025
Merged
Conversation
github-actions
bot
added
docker
Member
|
Is TARGETPLATFORM a build arg that can be passed? Usually it is always defined when using Buildx for creating multi-platform images, so it would be harmless to specify here too. Otherwise, add a somewhat dummy build arg to all other Dockerfiles, so you could pass one there. |
Member
|
What happens if the build arg is an empty string for the other Dockerfiles? The build-push action should be handling it, as it likely what happens when that input isn't set. |
Member
Author
|
It seems one can just pass an unused build-argument, e.g. "GUI=without" which is true but not used or defined in the Dockerfile for alpine or debian... |
echoix
reviewed
Dec 22, 2025
echoix
requested changes
Dec 22, 2025
echoix
reviewed
Dec 22, 2025
echoix
approved these changes
Dec 22, 2025
Member
|
@ninsbl You can re-add the auto-merge with your new message now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the separate Dockerfile for Ubuntu with WXGUI (in ubuntu_wxgui) and builds a docker image from the Ubuntu Dockerfile using the build-arg "GUI"
Since other OS did not use build args, unfortunately the "Build and push" step had to be duplicated to run either with build-args or without. Ideas on how to avoid that are welcome.
Please have a specific look also at caching, as I am not sure how that behaves (and if I got it right)...