make: pass GDAL include dirs to proj#6631
Merged
nilason merged 1 commit intoOSGeo:mainfrom Nov 17, 2025
Merged
Conversation
vector_inc and vedit_inc don't need this treatment as VECT_CFLAGS has it added already. This would conform to how its done in the CMakeLists.txt as well. Oddly enough this isn't a fatal error though. So if anyone hit a build failure and thought this was the issue should look further into their builds logs for the actual cause. Bug: OSGeo#4258 Signed-off-by: Alfred Wingate <[email protected]>
nilason
added
the
backport to 8.4
nilason
pushed a commit
that referenced
this pull request
Nov 17, 2025
vector_inc and vedit_inc don't need this treatment as VECT_CFLAGS has it added already. This would conform to how its done in the CMakeLists.txt as well. Oddly enough this isn't a fatal error though. So if anyone hit a build failure and thought this was the issue should look further into their builds logs for the actual cause. Bug: #4258 Signed-off-by: Alfred Wingate <[email protected]>
nilason
removed
the
backport to 8.4
Contributor
|
Backported with 7f27442. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vector_inc and vedit_inc don't need this treatment as VECT_CFLAGS has it
added already. This would conform to how its done in the CMakeLists.txt
as well.
Oddly enough this isn't a fatal error though. So if anyone hit a build
failure and thought this was the issue should look further into their
builds logs for the actual cause.
Bug: #4258
Why did I look at this? Because r.geomorphon actually segfaulted and while trying to find the error I ended up spending some time at this red herring.
#3731 (comment)