r.stream.extract: solve ties of equal flow accumulation#6554
Merged
petrasovaa merged 1 commit intoOSGeo:mainfrom Oct 28, 2025
Merged
r.stream.extract: solve ties of equal flow accumulation#6554petrasovaa merged 1 commit intoOSGeo:mainfrom
petrasovaa merged 1 commit intoOSGeo:mainfrom
Conversation
This was referenced Oct 26, 2025
petrasovaa
approved these changes
Oct 27, 2025
Contributor
petrasovaa
left a comment
petrasovaa
left a comment
There was a problem hiding this comment.
This makes sense and it does fix the issue. See my question about #6543.
petrasovaa
added a commit
that referenced
this pull request
Oct 28, 2025
…obust (#6543) This block got removed as part of compiler warnings cleanup #1248, but the removal broke special cases (#6541). The intention of r.stream.extract is to use external flow accumulation for stream extraction, but if in doubt follow the A* search direction, i.e. if (fabs(wat_nbr[np_side]) >= max_acc). Restoring this deleted code block in addition to #6554 should make r.stream.extract robust for special cases as reported in #6541.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of constant flow accumulation, e.g. to mask out areas where no streams should be traced, the flow direction method fails. With this PR, cases of equal flow accumulation are solved by following elevation.
Fixes #6541