r.stream.extract: fix stream delineation for binary flow accumulation#6543
r.stream.extract: fix stream delineation for binary flow accumulation#6543petrasovaa merged 1 commit intoOSGeo:mainfrom
Conversation
|
This change would break the intention of |
|
Thinking about it, this change does not break the intention of |
I see your PR fixes the issue, so I wonder if this PR is needed and why was the code block there to start with? |
As the code comment says To elaborate, the intention of Restoring this deleted code block with your PR in addition to my PR should make |
|
Since this is a bugfix, backport to G84? |
Fixes #6541.
This block got removed as part of compiler warnings cleanup #1248 with reasoning that part has been removed from r.watershed. But accumulation in r.stream.extract can be passed externally, so it makes sense the code is different. The actual warning was due to a misplaced parenthesis.
I tested it in the use case in #6541.
I also tested on NC elevation (there are no tests) and this changes the output vector slightly on several places:
r.watershed stream output (raster) matches the current state.
@metzm any idea?