docker: re-structure build stages for Ubuntu with and without GUI to optimize caching#6534
docker: re-structure build stages for Ubuntu with and without GUI to optimize caching#6534ninsbl merged 13 commits intoOSGeo:mainfrom
Conversation
ninsbl
added
docker
echoix
left a comment
echoix
left a comment
There was a problem hiding this comment.
The reordering of the Dockerfile should be working, but the gui logic path isn't ever used now in CI. That was my idea behind the #6512. Currently, it is using a separate ubuntu_wxgui Dockerfile.
Was your plan to have the Dockerfile changes merged first?
|
The other gui Dockerfile uses newer wxPython from pip (and the wxPython wheels from their website). I fixed it the other day when upgrading to Ubuntu 24.04. |
Yes, that was my thought. I can remove the "fix" keyword from the PR description if the issue was more about putting the different stages to good use in CI ... |
I did not test the GUI more than checking that it starts up without issues. If the pip version of wxPython is preferable, I can change that... |
echoix
changed the title
|
Backporting will be hard without the previous Dockerfile rewrite for 24.04 and building deps from source. |
I see. I think I will make a "backport PR"... |
nilason
removed
the
backport to 8.4
3 participants
Docker build cache can now be utilized if Ubuntu images are built incrementaly (e.g. first with and then without GUI, or the other way around). Time consuming compilation of dependencies is in a shared layer. GUI tested locally.