CI: Fix r.texture test on macOS for v8.4#6478
Merged
echoix merged 3 commits intoOSGeo:releasebranch_8_4from Oct 15, 2025
Merged
CI: Fix r.texture test on macOS for v8.4#6478echoix merged 3 commits intoOSGeo:releasebranch_8_4from
echoix merged 3 commits intoOSGeo:releasebranch_8_4from
Conversation
Attempt to fix:
```sh
Running ./raster/r.texture/testsuite/test_texture.py...
========================================================================
...........F.
======================================================================
FAIL: test_sv (__main__.TestRasterreport.test_sv)
Testing method sv
----------------------------------------------------------------------
Traceback (most recent call last):
File "raster/r.texture/testsuite/test_texture.py", line 144, in test_sv
self.assertRasterFitsUnivar(output, reference=values, precision=1e-2)
File "etc/python/grass/gunittest/case.py", line 289, in assertRasterFitsUnivar
self.assertModuleKeyValue(
File "etc/python/grass/gunittest/case.py", line 271, in assertModuleKeyValue
self.fail(self._formatMessage(msg, stdMsg))
AssertionError: r.univar map=sv_SV percentile=90.0 nprocs=1 separator== -g difference:
mismatch values (key, reference, actual): [('max', 45368496, 45368492), ('mean', 2248724.38215788, 2248724.35922656), ('variance', 2332049495199.41, 2332049429651.92)]
command: r.univar map=sv_SV percentile=90.0 nprocs=1 separator== -g {'map': 'sv_SV', 'separator': '=', 'flags': 'g'}
----------------------------------------------------------------------
Ran 13 tests in 17.655s
FAILED (failures=1)
```
github-actions
bot
added
raster
wenzeslaus
approved these changes
Oct 10, 2025
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
With your latest changes, it only adjusts the already inconsistent numbers, so I would say this is fine. You can link the actual fixes in the PR to make it clear that the ugliness is already resolved elsewhere.
Member
Author
|
Yes, I have edited the description above to refer to #5750 |
wenzeslaus
changed the title
Member
|
No opinion for me, but the justification by Vashek is fine: the numbers are probably wrong, so one wrong number for another is equivalent. |
echoix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix the following CI error (log) on
releasebranch_8_4by syncing tomain:Looks like an ugly workaround here but in G85 (#5750) this part has been rewritten and backporting is too much work (for me).