Conversation
|
As for the discussion on having a "DIGEST" label: In order to keep the DIGEST (and BASE_NAME arg) up to date we may add something like the following to renovate configuration (not tested and no idea if that is enough): That said, I can remove those labels if you feel it is not worth the hassle... |
The regex you show here might be missing something to match back to what to lookup for. I have some complex setup in the Megalinter repo where I extended the default common regex of Dockerfile to our custom yaml format and docs, so most of the updates are done at the right places. They have an example in their docs (unless they removed it since) where they show a common regex to start with, and to try to keep the same conventions as it allows the maximum configurability in most cases. It usually involves having a comment in the line above to add the extra data. |
echoix
left a comment
There was a problem hiding this comment.
Going as is. If we were to iterate, I think trying to avoid mentioning the image size would help not getting that info stale. And maybe double check that the download size is really 2.6 GB. There is a difference between the downloaded size, and the size of the built image non compressed. (And once extracted).
This PR updates the Ubuntu Dockerfile to use Ubuntu 24.04 as base image.
Usage of dynamic ARG is moved further down in the build process to not invalidate build cache.
The README has been updated to reflect the recent changes and esp. document how dynamic ARGs can be used to assign meaningful labels to the resulting docker image.