Merged
Conversation
metzm
added
bug
wenzeslaus
approved these changes
Sep 25, 2025
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
Looks good to me. It seems like we should have a library function for this.
I agree with the current behavior being a bug, although I'm not familiar with the history there. In relation to backport, it does not seem to me that anyone would rely on degradation of the type here, but waiting for a next release may reduce some surprises, so I don't feel strongly either way.
neteler
approved these changes
Sep 25, 2025
neteler
pushed a commit
that referenced
this pull request
Oct 2, 2025
neteler
removed
the
backport to 8.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
back then support for SQL type text (unlimited varchar) was added to
v.overlayand for reasons of backwards compatibility with dbf, columns of type "text" were converted to type "varchar(250)" which is not the same. The db drivers automatically convert text to varchar if text is not supported.This should be regarded as a bug because column types should not be changed by modules when copying columns.