CI: minimalistic flake8 backport to re-enable pre-commit and CI#6404
CI: minimalistic flake8 backport to re-enable pre-commit and CI#6404echoix merged 3 commits intoOSGeo:releasebranch_8_4from
Conversation
This PR is a minimalistic flake8 backport to re-enable pre-commit and CI in relbranch84.
|
I finally got to cherry pick the commit you had problems with, so better to rebase this branch here, as there will probably be conflicts |
There are still CI errors: run editorconfig-checker.................................................Failed
- hook id: editorconfig-checker
- exit code: 1
raster/r.reclass/testsuite/test_r_reclass.py:
8-9: Wrong indent style found (tabs instead of spaces)
vector/v.extract/testsuite/test_v_extract.py:
8-9: Wrong indent style found (tabs instead of spaces)
2 errors found
scripts/r.reclass.area/testsuite/testrra.py:
8-9: Wrong indent style found (tabs instead of spaces)
... |
|
Yep, we've gone a long way since 8.4 in improving the quality. When discussing offline, I mentioned some of the commits that fixed these issues before that change was made. So, to also cherry pick (at least some parts of): That's what I had found before, it might not be enough still for these issues |
I am sorry, this is beyond my git skills (just messed up again my local copy)... |
|
...also disabling problematic checks is acceptable for older release branches, I would say, even if it means also disabling local pre-commit. Whatever is easier. |
This PR is a minimalistic flake8 settings backport to re-enable pre-commit and CI in relbranch84.