Conversation
This PR fixes the limitation to 16 bits by replacing `short` type to `integer`.
Example (now fixed):
```bash
GRASS latlong_wgs84/mymapset:grass >
g.region vector=solar_panels_points -m
projection=3
zone=0
n=56.62055
s=47
w=5.451694
e=14.991018
nsres=30.9064117
ewres=19.07598674
rows=34634
cols=34342
cells=1189400828
```
One giga-pixels (34k x 34k) is not that much. Yet it overflowed:
```bash
r.surf.idw input=solar_panels output=heatmap_idw_rast
Current region rows: 34634, cols: 34342
ERROR: G_calloc: unable to allocate 18446744073709520714 * 40 bytes of
memory at raster/r.surf.idw/dist.c:43
```
This PR fixes this limitation.
Co-authored-by: @metzm
neteler
added
bug
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Looks good to me!
(Wonder why using short in the first place).
Guess it stems from very old times: it is already in the code snippet from > 20 years ago: |
Seems like yesterday :). I suspected that was the reason. |
neteler
removed
the
backport to 8.4
2 participants
This PR fixes the limitation to 16 bits by replacing
shorttype tointeger.Example (now fixed):
GRASS latlong_wgs84/mymapset:grass > g.region vector=solar_panels_points -m projection=3 zone=0 n=56.62055 s=47 w=5.451694 e=14.991018 nsres=30.9064117 ewres=19.07598674 rows=34634 cols=34342 cells=1189400828One giga-pixels (34k x 34k) is not that much. Yet it overflowed:
r.surf.idw input=solar_panels output=heatmap_idw_rast Current region rows: 34634, cols: 34342 ERROR: G_calloc: unable to allocate 18446744073709520714 * 40 bytes of memory at raster/r.surf.idw/dist.c:43This PR fixes this limitation.
Co-authored-by: @metzm