Skip to content

Comments

v.overlay: fix collapsed lines after snapping#6388

Merged
metzm merged 1 commit intoOSGeo:mainfrom
metzm:v.overlay_snap_point
Sep 22, 2025
Merged

v.overlay: fix collapsed lines after snapping#6388
metzm merged 1 commit intoOSGeo:mainfrom
metzm:v.overlay_snap_point

Conversation

@metzm
Copy link
Contributor

@metzm metzm commented Sep 21, 2025

Vect_snap_line() can reduce lines/boundaries to zero-length lines with only one vertex. Such lines with only one vertex are not supported by Vect_break_lines_list(). Deleting these lines/boundaries is apparently safe because adjoining lines/boundaries will be snapped to the same anchor point, preserving topology. This PR adds a check if a line has been collapsed to one vertex and deletes such lines.

@metzm metzm added this to the 8.5.0 milestone Sep 21, 2025
@metzm metzm requested a review from nilason September 21, 2025 16:10
@metzm metzm added bug Something isn't working vector Related to vector data processing C Related code is in C backport to 8.4 PR needs to be backported to release branch 8.4 labels Sep 21, 2025
@metzm metzm merged commit 676d500 into OSGeo:main Sep 22, 2025
27 checks passed
@metzm metzm deleted the v.overlay_snap_point branch September 22, 2025 13:35
metzm added a commit that referenced this pull request Sep 22, 2025
@metzm
Copy link
Contributor Author

metzm commented Sep 22, 2025

Backported to G84

@neteler neteler removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Oct 2, 2025
@neteler neteler modified the milestones: 8.5.0, 8.4.2 Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working C Related code is in C module vector Related to vector data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants