r.regression.multi: Add test file#6066
Merged
petrasovaa merged 2 commits intoOSGeo:mainfrom Jul 17, 2025
Merged
Conversation
Signed-off-by: Nishant Bansal <[email protected]>
github-actions
bot
added
raster
echoix
approved these changes
Jul 15, 2025
Contributor
|
@echoix do you know what's up with the crlf action? |
echoix
added a commit
that referenced
this pull request
Jul 17, 2025
…6070) Simplified and adapted from #4792. Fixes #6066 (comment) The action that checks for CRLF has been failing since at least this weekend. Considering that that action has low chances of beeing fixed in a timely matter, I replaced the functionality with an .editorconfig file and validating against it with editorconfig-checker. Compared to #4792, here I don’t attempt to make the line ending changes persist in the repo through .gitattributes, and ignore a bit more of non-ready config sections (since the functionality replaced was less detailed than what the .editorconfig I already had almost working). I made the pre-commit run always, and made it faster in consequence to not add a big impact. With hot cache, it is taking 1min-1min10, which is about the same. I knew pre-commit could be faster in CI as I already saw how fast it was in ruff’s own CI when submitting one of my PRs there once. It can still be a bit faster, but it’s enough for today. * CQ: Add initial .editorconfig file with basic settings * CI: Add EditorConfig validation to super-linter workflow * CI: Remove CRLF check from additional_checks.yml workflow * CQ: Add editorconfig-checker to pre-commit config * CI: Always run pre-commit in CI * Update .editorconfig with new whitespace settings for mswindows * CI: Run pre-commit step with uvx * CI: Add caching for pre-commit checks in workflow * Update .editorconfig for Windows batch files * CI: Remove paths-filter step from additional_checks.yml * Update additional_checks.yml step setup-uv
github-project-automation
bot
moved this from In Progress
to Done
in GRASS JSON Outputs
echoix
added a commit
to echoix/grass
that referenced
this pull request
Sep 21, 2025
…SGeo#6070) Simplified and adapted from OSGeo#4792. Fixes OSGeo#6066 (comment) The action that checks for CRLF has been failing since at least this weekend. Considering that that action has low chances of beeing fixed in a timely matter, I replaced the functionality with an .editorconfig file and validating against it with editorconfig-checker. Compared to OSGeo#4792, here I don’t attempt to make the line ending changes persist in the repo through .gitattributes, and ignore a bit more of non-ready config sections (since the functionality replaced was less detailed than what the .editorconfig I already had almost working). I made the pre-commit run always, and made it faster in consequence to not add a big impact. With hot cache, it is taking 1min-1min10, which is about the same. I knew pre-commit could be faster in CI as I already saw how fast it was in ruff’s own CI when submitting one of my PRs there once. It can still be a bit faster, but it’s enough for today. * CQ: Add initial .editorconfig file with basic settings * CI: Add EditorConfig validation to super-linter workflow * CI: Remove CRLF check from additional_checks.yml workflow * CQ: Add editorconfig-checker to pre-commit config * CI: Always run pre-commit in CI * Update .editorconfig with new whitespace settings for mswindows * CI: Run pre-commit step with uvx * CI: Add caching for pre-commit checks in workflow * Update .editorconfig for Windows batch files * CI: Remove paths-filter step from additional_checks.yml * Update additional_checks.yml step setup-uv
echoix
added a commit
to echoix/grass
that referenced
this pull request
Sep 25, 2025
…SGeo#6070) Simplified and adapted from OSGeo#4792. Fixes OSGeo#6066 (comment) The action that checks for CRLF has been failing since at least this weekend. Considering that that action has low chances of beeing fixed in a timely matter, I replaced the functionality with an .editorconfig file and validating against it with editorconfig-checker. Compared to OSGeo#4792, here I don’t attempt to make the line ending changes persist in the repo through .gitattributes, and ignore a bit more of non-ready config sections (since the functionality replaced was less detailed than what the .editorconfig I already had almost working). I made the pre-commit run always, and made it faster in consequence to not add a big impact. With hot cache, it is taking 1min-1min10, which is about the same. I knew pre-commit could be faster in CI as I already saw how fast it was in ruff’s own CI when submitting one of my PRs there once. It can still be a bit faster, but it’s enough for today. * CQ: Add initial .editorconfig file with basic settings * CI: Add EditorConfig validation to super-linter workflow * CI: Remove CRLF check from additional_checks.yml workflow * CQ: Add editorconfig-checker to pre-commit config * CI: Always run pre-commit in CI * Update .editorconfig with new whitespace settings for mswindows * CI: Run pre-commit step with uvx * CI: Add caching for pre-commit checks in workflow * Update .editorconfig for Windows batch files * CI: Remove paths-filter step from additional_checks.yml * Update additional_checks.yml step setup-uv
echoix
added a commit
that referenced
this pull request
Sep 25, 2025
…6070) Simplified and adapted from #4792. Fixes #6066 (comment) The action that checks for CRLF has been failing since at least this weekend. Considering that that action has low chances of beeing fixed in a timely matter, I replaced the functionality with an .editorconfig file and validating against it with editorconfig-checker. Compared to #4792, here I don’t attempt to make the line ending changes persist in the repo through .gitattributes, and ignore a bit more of non-ready config sections (since the functionality replaced was less detailed than what the .editorconfig I already had almost working). I made the pre-commit run always, and made it faster in consequence to not add a big impact. With hot cache, it is taking 1min-1min10, which is about the same. I knew pre-commit could be faster in CI as I already saw how fast it was in ruff’s own CI when submitting one of my PRs there once. It can still be a bit faster, but it’s enough for today. * CQ: Add initial .editorconfig file with basic settings * CI: Add EditorConfig validation to super-linter workflow * CI: Remove CRLF check from additional_checks.yml workflow * CQ: Add editorconfig-checker to pre-commit config * CI: Always run pre-commit in CI * Update .editorconfig with new whitespace settings for mswindows * CI: Run pre-commit step with uvx * CI: Add caching for pre-commit checks in workflow * Update .editorconfig for Windows batch files * CI: Remove paths-filter step from additional_checks.yml * Update additional_checks.yml step setup-uv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #6010
This PR adds a regression test suite for the
r.regression.multimodule. These tests are intended to serve as regression checks for upcoming PRs that add JSON support tor.regression.multi.