Skip to content

Comments

CI(OSGeo4W): Upgrade image to windows-2022 (backport of #5562)#5902

Merged
echoix merged 2 commits intoOSGeo:releasebranch_8_4from
echoix:windows-2022-backport84
Jun 17, 2025
Merged

CI(OSGeo4W): Upgrade image to windows-2022 (backport of #5562)#5902
echoix merged 2 commits intoOSGeo:releasebranch_8_4from
echoix:windows-2022-backport84

Conversation

@echoix
Copy link
Member

@echoix echoix commented Jun 17, 2025

Backport of #5562

The windows-2019 image is being removed in less than a month. We need to use windows-2022. The changes needed in our build_osgeo4w.sh script relate to the msys2 paths added to path. They need to use the location defined in the CI step, otherwise, another version already installed in the runner, but normally not on path, is used. On windows-2019, we didn’t see errors of this misconfiguration, but we did for windows-2022.

  • CI(OSGeo4W): Upgrade image to windows-2022

  • mswindows: Update path for dumpbin in mklibs.sh

  • windows: Use MSYS2_LOCATION env var to create script from templates in build_osgeo4w.sh

  • CI(OSGeo4W): Add MSYS2_LOCATION env var to build stage

The windows-2019 image is being removed in less than a month. We need
to use windows-2022. The changes needed in our build_osgeo4w.sh script
relate to the msys2 paths added to path. They need to use the location
defined in the CI step, otherwise, another version already installed
in the runner, but normally not on path, is used. On windows-2019, we
didn’t see errors of this misconfiguration, but we did for
windows-2022.

* CI(OSGeo4W): Upgrade image to windows-2022

* mswindows: Update path for dumpbin in mklibs.sh

* windows: Use MSYS2_LOCATION env var to create script from templates
in build_osgeo4w.sh

* CI(OSGeo4W): Add MSYS2_LOCATION env var to build stage
@github-actions github-actions bot added windows Microsoft Windows specific CI Continuous integration labels Jun 17, 2025
@echoix
Copy link
Member Author

echoix commented Jun 17, 2025

Top many failed tests. Need to check out what's missing

The windows-2019 image is being removed in less than a month. We need
to use windows-2022. The changes needed in our build_osgeo4w.sh script
relate to the msys2 paths added to path. They need to use the location
defined in the CI step, otherwise, another version already installed
in the runner, but normally not on path, is used. On windows-2019, we
didn’t see errors of this misconfiguration, but we did for
windows-2022.

* CI(OSGeo4W): Upgrade image to windows-2022

* mswindows: Update path for dumpbin in mklibs.sh

* windows: Use MSYS2_LOCATION env var to create script from templates
in build_osgeo4w.sh

* CI(OSGeo4W): Add MSYS2_LOCATION env var to build stage
@echoix
Copy link
Member Author

echoix commented Jun 17, 2025

16 minutes to run the r.univar test... but it made it. I don't expect this run to have enough passing tests.

@echoix
Copy link
Member Author

echoix commented Jun 17, 2025

16 minutes to run the r.univar test... but it made it. I don't expect this run to have enough passing tests.

81% of the files passed, it is like before for releasebranch_8_4.
I'm launching a rerun of the first commit to make sure upgrading the base msys2 action version was really required.

@echoix
Copy link
Member Author

echoix commented Jun 17, 2025

It was needed. It failed in the same way after the same amount of time.

@echoix echoix merged commit 3bb1287 into OSGeo:releasebranch_8_4 Jun 17, 2025
26 checks passed
@echoix echoix deleted the windows-2022-backport84 branch June 17, 2025 16:23
@neteler neteler added this to the 8.4.2 milestone Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration windows Microsoft Windows specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants