r.slope.aspect: Increase precision of values compared in tests#5796
Merged
echoix merged 11 commits intoOSGeo:mainfrom May 30, 2025
Merged
r.slope.aspect: Increase precision of values compared in tests#5796echoix merged 11 commits intoOSGeo:mainfrom
echoix merged 11 commits intoOSGeo:mainfrom
Conversation
longer supported in GDAL >=3.11.0 Fixes bug OSGeo#5787
This reverts commit ed9e6c7.
This reverts commit dc79e6e.
This reverts commit 22db130.
github-actions
bot
added
raster
marisn
requested changes
May 30, 2025
echoix
commented
May 30, 2025
Member
Author
echoix
left a comment
echoix
left a comment
There was a problem hiding this comment.
I agree that the message could be different, I tried something else
marisn
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #5792.
This PR uses a smaller delta for the differences accepted between actual and reference values. The current tests were quite loose, and would probably not help us catch regressions unless the differences were huge. Since it is mostly a golden test, we want to know when anything changes.