r.slope.aspect: replace GSAG test data with AAGRID#5792
Conversation
longer supported in GDAL >=3.11.0 Fixes bug OSGeo#5787
|
How did you convert them? The previous files have some values that are represented exactly as "1.70141E+38", but the NODATA value here is "NODATA_value 1.701410000000000071e+38", and that number is found multiple times. Would this be affecting the stats/snapshots we might have taken? |
|
Pure gdal_translate without any extra options. I thought about DECIMAL_PRECISION, but that could change obtained results. |
github-actions
bot
added
raster
neteler
added
the
backport to 8.4
echoix
left a comment
echoix
left a comment
There was a problem hiding this comment.
I tried out locally, what would be the difference if keeping the original amount of digits (without adding some approximate ones near the end). There was no difference.
Except that I realized that the precision requested was quite low, for two numbers that have an error in the 6e-5 range. Other than that, two reference values only had 5 digits or so, and then the rest can use 1e-14 precision (except one that fails at 1e11). Note that it isn't using relative error, so 1e-11 can mean the same when the number compared is already small.
I could file that work in another PR if needed. Important for now is to unblock PRs to the repo.
|
I updated the PRs that were blocked by this |
Follow-up from #5792. This PR uses a smaller delta for the differences accepted between actual and reference values. The current tests were quite loose, and would probably not help us catch regressions unless the differences were huge. Since it is mostly a golden test, we want to know when anything changes. * Increase r.slope.aspect precision * Add more digits to the reference mean values of test_slope * Increase r.slope.aspect precision to 1e-14, except where results fail * Add note to use a smaller precision threshold or self.precision * Apply suggestions from code review
GDAL >=3.11.0 does not support GSAG any more. This PR just replaces GSAG files with ones converted to AAGRID. Fixes bug #5787
nilason
removed
the
backport to 8.4
4 participants
GDAL >=3.11.0 does not support GSAG any more. This PR just replaces GSAG files with ones converted to AAGRID.
Fixes bug #5787