r.univar: Use Kahan sum to avoid floating point errors#5750
Merged
echoix merged 26 commits intoOSGeo:mainfrom May 24, 2025
Merged
r.univar: Use Kahan sum to avoid floating point errors#5750echoix merged 26 commits intoOSGeo:mainfrom
echoix merged 26 commits intoOSGeo:mainfrom
Conversation
github-actions
bot
added
raster
marisn
requested changes
May 23, 2025
nilason
requested changes
May 23, 2025
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Following files fails on Mac CI:
- raster/r.mfilter/testsuite/test_r_mfilter.py
- raster/r.resamp.filter/testsuite/test_r_resamp_filter.py
- raster/r.resamp.interp/testsuite/test_r_resamp_interp.py
marisn
previously approved these changes
May 23, 2025
echoix
reviewed
May 24, 2025
cyliang368
changed the title
This should make the main README.md more useful and readable. The docker part was moved to docker/README. --------- Co-authored-by: Veronica Andreo <[email protected]>
This introduces the possibility of using the temporal framework and switching mapset within the same session. This should address issue OSGeo#629. * call g.mapsets instead of direct calls to C funcs * query current mapset name explicitly
auto-merge was automatically disabled
May 24, 2025 14:16
Head branch was pushed to by a user without write access
nilason
approved these changes
May 24, 2025
cyliang368
changed the title
This was referenced Oct 8, 2025
nilason
added
the
backport to 8.4
Contributor
|
Tagging this for backport so we do not forget it. To be discussed... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Univar sums values across large amounts of numbers, so the floating point errors could be huge if a naive sum is applied.
This PR introduces Kahan sum to solve this problem in
r.univar. The testing reference numbers derived from the previousr.univarimplementation are also updated.