Skip to content

Comments

g.region: fix save option behavior#5627

Merged
petrasovaa merged 1 commit intoOSGeo:mainfrom
petrasovaa:g.region-fix-save-option-behavior
May 13, 2025
Merged

g.region: fix save option behavior#5627
petrasovaa merged 1 commit intoOSGeo:mainfrom
petrasovaa:g.region-fix-save-option-behavior

Conversation

@petrasovaa
Copy link
Contributor

Adjust the region before saving it. Before, setting rows= and cols= had no effect on the saved region.

Fixes #5625.

Adjust the region before saving it. Before, setting rows= and cols= had no effect on the saved region.
@github-actions github-actions bot added C Related code is in C module general labels May 8, 2025
@petrasovaa petrasovaa requested a review from metzm May 8, 2025 19:20
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implements the suggestion in the related issue

@petrasovaa petrasovaa merged commit 299a28a into OSGeo:main May 13, 2025
28 of 29 checks passed
@petrasovaa petrasovaa deleted the g.region-fix-save-option-behavior branch May 13, 2025 17:59
@github-actions github-actions bot added this to the 8.5.0 milestone May 13, 2025
@neteler neteler added the backport to 8.4 PR needs to be backported to release branch 8.4 label May 14, 2025
@metzm
Copy link
Contributor

metzm commented May 14, 2025

You have not removed the use of temp_window which can lead to confusion in maintenance later on.

echoix pushed a commit that referenced this pull request May 17, 2025
Follow up on #5627. temp_window is still used elsewhere, so it should not be removed completely.
nilason pushed a commit that referenced this pull request Nov 18, 2025
Adjust the region before saving it. Before, setting rows= and cols= had no effect on the saved region.
nilason pushed a commit that referenced this pull request Nov 18, 2025
Follow up on #5627. temp_window is still used elsewhere, so it should not be removed completely.
@nilason nilason removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 18, 2025
@nilason nilason modified the milestones: 8.5.0, 8.4.2 Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C general module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] g.region: inconsistent behavior of save option

5 participants