CQ: always include stdbool.h if bool is used in C code#5618
Merged
nilason merged 1 commit intoOSGeo:mainfrom May 6, 2025
Merged
CQ: always include stdbool.h if bool is used in C code#5618nilason merged 1 commit intoOSGeo:mainfrom
nilason merged 1 commit intoOSGeo:mainfrom
Conversation
Always `#include <stdbool.h>` where `bool` is used. For the same reason, revert (part of 1e0c11f) definition of `TRUE` and `FALSE` (in gis.h) to `1` and `0`, in order to avoid the inclusion everywhere it may/should have been needed. In addition, starting with C23 `bool` is not an int, but a type of its own, making it not interchangeable with int.
github-actions
bot
added
vector
nilason
changed the title
echoix
approved these changes
May 6, 2025
Member
|
@nilason shall I backport this? Looks like important to me... |
Contributor
Author
Member
|
It already had the backport label. But the #5621 is more important: newer OSGeo4W builds will probably not work without when using GCC15, and will definitely not work in CI. |
Member
Sure, but someone (who?) has to actually do it :-) |
nilason
added a commit
that referenced
this pull request
Nov 17, 2025
Always `#include <stdbool.h>` where `bool` is used i C code. For the same reason, revert (part of 1e0c11f) definition of `TRUE` and `FALSE` (in gis.h) to `1` and `0`, in order to avoid the inclusion everywhere it may/should have been needed. In addition, starting with C23 `bool` is not an int, but a type of its own, making it not interchangeable with int.
nilason
removed
the
backport to 8.4
nilason
added a commit
that referenced
this pull request
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always
#include <stdbool.h>whereboolis used.For the same reason, revert (part of 1e0c11f) definition of
TRUEandFALSE(in gis.h) to1and0, in order to avoid the inclusion everywhere it may/should have been needed. In addition, starting with C23boolis not an int, but a type of its own, making it not interchangeable with int.Fixes #5585