r.plane: remove misused gisprompt option#5601
Conversation
As the option does not contain a comma separated three part string, this causes heap buffer overflow.
|
It looks like "options" or whatever the allowed values are called. |
They are passed to the module parser and G__split_gisprompt() assumes the option value is correct: Line 1773 in 2e55b15 During compilation this is triggered by documentation generation (calling parser html|md). |
|
I don't doubt this fails. What I meant is that there is example: https://github.com/OSGeo/grass/blob/main/raster/r.viewshed/main.cpp#L509 |
Aha, now I see what you mean, you suggest something like: - # % gisprompt: -90-90
+ # % options: -90-90 |
|
Yes! |
|
Now I changed to use "options". |
Replace misused ’gisprompt’ option to ’options’. As the gisprompt option does not contain a comma separated three part string, this causes heap buffer overflow.
As the option does not contain a comma separated three part string, this causes heap buffer overflow. This is probably the cause of some random CI failures with
r.plane.Follow-up to #5493.