g.remove: improve user message to contain more details#5484
Merged
echoix merged 1 commit intoOSGeo:mainfrom Apr 1, 2025
neteler:g_remove_improve_message
Merged
g.remove: improve user message to contain more details#5484echoix merged 1 commit intoOSGeo:mainfrom neteler:g_remove_improve_message
echoix merged 1 commit intoOSGeo:mainfrom
neteler:g_remove_improve_message
Conversation
I find it unhelpful that `g.remove` is unspecific with its "file not found" message, e.g. ```bash g.remove -f type=vector 'pattern=voronoi*' WARNING: No data base element files found g.remove -f type=raster,vector 'pattern=map*' WARNING: No data base element files found g.remove -f type=raster 'pattern=model*' WARNING: No data base element files found g.remove -f type=vector 'pattern=ato*' WARNING: No data base element files found ``` Running this in scripted (cloud) environments may flood the logs with messages not helpful for debugging. This PR changes the message to ```bash g.remove -f type=raster 'pattern=bla*' No file(s) found for type(s): raster g.remove -f type=region 'pattern=bla*' No file(s) found for type(s): region g.remove -f type=all 'pattern=bla*' No file(s) found for type(s): raster, raster_3d, vector, region, group ``` Co-authored-by: Nicklas Larsson <[email protected]>
nilason
approved these changes
Apr 1, 2025
neteler
added a commit
that referenced
this pull request
Apr 2, 2025
g.remove: I find it unhelpful that `g.remove` is unspecific with its "file not found" message, e.g. ```bash g.remove -f type=vector 'pattern=voronoi*' WARNING: No data base element files found g.remove -f type=raster,vector 'pattern=map*' WARNING: No data base element files found g.remove -f type=raster 'pattern=model*' WARNING: No data base element files found g.remove -f type=vector 'pattern=ato*' WARNING: No data base element files found ``` Running this in scripted (cloud) environments may flood the logs with messages not helpful for debugging. This PR changes the message to ```bash g.remove -f type=raster 'pattern=bla*' No file(s) found for type(s): raster g.remove -f type=region 'pattern=bla*' No file(s) found for type(s): region g.remove -f type=all 'pattern=bla*' No file(s) found for type(s): raster, raster_3d, vector, region, group ``` Co-authored-by: Nicklas Larsson <[email protected]>
Kiraschild
pushed a commit
to Kiraschild/grass
that referenced
this pull request
Apr 4, 2025
g.remove: I find it unhelpful that `g.remove` is unspecific with its "file not found" message, e.g. ```bash g.remove -f type=vector 'pattern=voronoi*' WARNING: No data base element files found g.remove -f type=raster,vector 'pattern=map*' WARNING: No data base element files found g.remove -f type=raster 'pattern=model*' WARNING: No data base element files found g.remove -f type=vector 'pattern=ato*' WARNING: No data base element files found ``` Running this in scripted (cloud) environments may flood the logs with messages not helpful for debugging. This PR changes the message to ```bash g.remove -f type=raster 'pattern=bla*' No file(s) found for type(s): raster g.remove -f type=region 'pattern=bla*' No file(s) found for type(s): region g.remove -f type=all 'pattern=bla*' No file(s) found for type(s): raster, raster_3d, vector, region, group ``` Co-authored-by: Nicklas Larsson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it unhelpful that
g.removeis unspecific with its "file not found" message, e.g.Running this in scripted (cloud) environments may flood the logs with messages not helpful for debugging.
This PR changes the message to
Co-authored-by: @nilason