Skip to content

Comments

gui: add README.md and LICENSE.TXT for icons#5387

Merged
echoix merged 2 commits intoOSGeo:mainfrom
neteler:gui_icons_readme_license
Mar 31, 2025
Merged

gui: add README.md and LICENSE.TXT for icons#5387
echoix merged 2 commits intoOSGeo:mainfrom
neteler:gui_icons_readme_license

Conversation

@neteler
Copy link
Member

@neteler neteler commented Mar 14, 2025

This PR adds a README.md containing author @Cracert, license and source of icon files.

Also adding LICENSE.TXT as required by icon license.

This PR adds a `README.md` containing author @Cracert, license and source of icon files.

Also adding `LICENSE.TXT` as required by icon license.
@neteler neteler added GUI wxGUI related backport to 7.8 PR needs to be backported to release branch 7.8 backport to 8.4 PR needs to be backported to release branch 8.4 labels Mar 14, 2025
@neteler neteler added this to the 8.5.0 milestone Mar 14, 2025
@neteler neteler requested a review from echoix March 14, 2025 13:34
@github-actions github-actions bot added docs markdown Related to markdown, markdown files labels Mar 14, 2025
@nilason
Copy link
Contributor

nilason commented Mar 14, 2025

@neteler
Copy link
Member Author

neteler commented Mar 14, 2025

Ouch, fixed.

@echoix
Copy link
Member

echoix commented Mar 14, 2025

Do we need to copy the license file in the built software?

@neteler
Copy link
Member Author

neteler commented Mar 17, 2025

The license statement is "I only ask you to let me know about that and to include licence.txt file in your work."

So, sounds like "to be included" - however, @Cracert may decide.

Copy link
Contributor

@veroandreo veroandreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo

@echoix
Copy link
Member

echoix commented Mar 17, 2025

Small typo

It's written that way in the repo, in the file we need to include. Maybe make that suggestion in his repo?

@echoix
Copy link
Member

echoix commented Mar 31, 2025

Per @Cracert response by mail, it is not needed to have the license text file copied on installation:

Hello Robert,
We have a question regarding how to respect your licensing wishes here, would you mind jumping in to clarify if the license text must simply be in the source code, or must be copied over on each end user’s installation as well?

Hello Edouard,

There is no reason to spam users with such files, so please choose a simpler solution.
Thanks guys for your work!

Kind regards,
Robert Szczepnek

@echoix echoix merged commit 8c18d35 into OSGeo:main Mar 31, 2025
28 checks passed
@neteler neteler deleted the gui_icons_readme_license branch April 1, 2025 07:28
neteler added a commit that referenced this pull request Apr 2, 2025
* gui: add README.md and LICENSE.TXT for icons

This PR adds a `README.md` containing author @Cracert, license and source of icon files.

Also adding `LICENSE.TXT` as required by icon license.

* use ASCII version of LICENSE.TXT
neteler added a commit that referenced this pull request Apr 2, 2025
* gui: add README.md and LICENSE.TXT for icons

This PR adds a `README.md` containing author @Cracert, license and source of icon files.

Also adding `LICENSE.TXT` as required by icon license.

* use ASCII version of LICENSE.TXT
@neteler neteler modified the milestones: 8.5.0, 8.4.2 Apr 2, 2025
@neteler neteler removed backport to 7.8 PR needs to be backported to release branch 7.8 backport to 8.4 PR needs to be backported to release branch 8.4 labels Apr 2, 2025
@neteler neteler modified the milestones: 8.4.2, 7.8.9 Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs GUI wxGUI related markdown Related to markdown, markdown files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants