wxGUI/gmodeler: fix setToolBar failing on macOS#5298
Merged
pesekon2 merged 6 commits intoOSGeo:mainfrom Mar 5, 2025
Merged
Conversation
nilason
requested changes
Mar 4, 2025
tested and proposed by @nilason
nilason
approved these changes
Mar 5, 2025
pesekon2
added a commit
that referenced
this pull request
Mar 5, 2025
* fix needed for macOS does not seem to be needed after wx 4.2.1; it seems to break the tool instead tested and proposed by @nilason
Contributor
Author
|
Cherry-picked to releasebranch_8_4 in 797f1cf |
pesekon2
removed
the
backport to 8.4
echoix
pushed a commit
to echoix/grass
that referenced
this pull request
Mar 8, 2025
* fix needed for macOS does not seem to be needed after wx 4.2.1; it seems to break the tool instead tested and proposed by @nilason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug seems to be in wxpython: wxWidgets/wxWidgets#24560
One of the workarounds mentioned in the linked issue is to call
Realize()beforesetToolBar()- this is an attempt to fix it with this trick