Skip to content

Comments

CI: use SQLite <3.49.0 on macOS#5196

Merged
echoix merged 1 commit intoOSGeo:mainfrom
echoix:macos-sqlite
Feb 23, 2025
Merged

CI: use SQLite <3.49.0 on macOS#5196
echoix merged 1 commit intoOSGeo:mainfrom
echoix:macos-sqlite

Conversation

@echoix
Copy link
Member

@echoix echoix commented Feb 23, 2025

Cherry pick of @nilason's commit on releasebranch_8_4

Co-authored-by: Nicklas Larsson <[email protected]>
@echoix echoix requested a review from nilason February 23, 2025 13:43
@github-actions github-actions bot added the macOS macOS specific label Feb 23, 2025
@echoix
Copy link
Member Author

echoix commented Feb 23, 2025

We would probably need to do a change anyways sometime soon, see the justification and what is encouraged here: https://www.sqlite.org/quirks.html#dblquote

Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make an issue of addressing this properly, so we won’t forget.

@echoix
Copy link
Member Author

echoix commented Feb 23, 2025

Could you please make an issue of addressing this properly, so we won’t forget.

Done in #5197

@echoix echoix merged commit bde7171 into OSGeo:main Feb 23, 2025
23 checks passed
@echoix echoix deleted the macos-sqlite branch February 23, 2025 15:10
@github-actions github-actions bot added this to the 8.5.0 milestone Feb 23, 2025
@nilason
Copy link
Contributor

nilason commented Feb 23, 2025

Could you please make an issue of addressing this properly, so we won’t forget.

Done in #5197

Thanks!

@echoix
Copy link
Member Author

echoix commented Mar 16, 2025

By the way, they finally fixed it in conda-forge/sqlite-feedstock#132, from the issue conda-forge/sqlite-feedstock#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macOS macOS specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants