docker: gdal-grass autoconf workaround (G84)#5123
Merged
neteler merged 1 commit intoOSGeo:releasebranch_8_4from Feb 16, 2025
neteler:docker_gdal-grass_autoconf_workaround
Merged
docker: gdal-grass autoconf workaround (G84)#5123neteler merged 1 commit intoOSGeo:releasebranch_8_4from neteler:docker_gdal-grass_autoconf_workaround
neteler merged 1 commit intoOSGeo:releasebranch_8_4from
neteler:docker_gdal-grass_autoconf_workaround
Conversation
This PR hardcodes the gdal-grass 1.0.3 release in the Alpine and Ubuntu Dockerfile to make use of `autoconf`. It may be replaces with a future backport of a `cmake` based solution. The intention is to not further postpone the GRASS 8.4.1 release.
Member
|
Until I finish my PR (actively working on it) that will allow to test Docker on PRs, can you make sure that the Dockerfile works locally? |
Member
Author
|
Quick local micro-tests: # GRASS GIS test
docker run -it --rm b07a3e207f0037542fb11410c43ab99887d7c27e73d1bff7b3cf34b40a44da36 grass --version
GRASS GIS 8.4.1dev
...Yes, this works. |
Member
|
What dockerfile was it? Was it the alpine one? |
nilason
approved these changes
Feb 15, 2025
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Thanks, as this uses the original autoconf settings which still is unmodified in 1.0.3, this will surely work!
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardcodes the gdal-grass 1.0.3 release in the Alpine and Ubuntu Dockerfile to continue using its
autoconfsupport.This PR may be replaced by a future backport of a
cmakebased solution which is being worked on in themainbranch.The intention of this PR is not to further delay the GRASS 8.4.1 release due to currently broken Dockerfiles.