Skip to content

Comments

docker: build gdal-grass with grass in working condition#5115

Merged
wenzeslaus merged 3 commits intoOSGeo:mainfrom
nilason:docker_again
Feb 14, 2025
Merged

docker: build gdal-grass with grass in working condition#5115
wenzeslaus merged 3 commits intoOSGeo:mainfrom
nilason:docker_again

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Feb 14, 2025

#5111 was not enough to fix the Alpine docker build. gdal-grass CMake config uses grass for setting paths and requires a working state of grass.

This was not the case because of:

RUN mv $(grass --config path) /usr/local/grass

just before the gdal-grass build started.

This moves the gdal-grass build immediately after grass is built, this hopefully will solve this issue.

@nilason nilason added this to the 8.5.0 milestone Feb 14, 2025
@github-actions github-actions bot added the docker Docker related label Feb 14, 2025
@wenzeslaus
Copy link
Member

So that line breaks grass?

Is this now in sync with Ubuntu?

@nilason
Copy link
Contributor Author

nilason commented Feb 14, 2025

So that line breaks grass?

There are copying operations later on, which "fix" that. Without being able to test locally, this solution seems the best one.

Is this now in sync with Ubuntu?

The Dockerfiles are differently organised. So this (seemingly) doesn't affect the other Dockers.

@nilason
Copy link
Contributor Author

nilason commented Feb 14, 2025

Shall we try this out?

@wenzeslaus wenzeslaus merged commit d657e54 into OSGeo:main Feb 14, 2025
26 checks passed
@wenzeslaus
Copy link
Member

So that line breaks grass?

There are copying operations later on, which "fix" that. Without being able to test locally, this solution seems the best one.

I guess I just don't understand the current Docker enough to know why is that needed.

@echoix
Copy link
Member

echoix commented Feb 14, 2025

Is there a problem preventing to try locally? Like does it work on macOS too?

@nilason
Copy link
Contributor Author

nilason commented Feb 14, 2025

Is there a problem preventing to try locally?

Probably not.

Like does it work on macOS too?

Don't know. I never tried the Docker road. Couple of years ago, looking at it, I was hold back because of the space required. Then never really felt the need to.

@nilason
Copy link
Contributor Author

nilason commented Feb 14, 2025

Ahhrr, builds but not working properly:

#23 3.342 ERROR 1: Error loading shared library libgrass_raster.8.5.so: No such file or directory (needed by /usr/lib/gdalplugins/gdal_GRASS.so)
#23 3.342 ERROR 1: Error loading shared library libgrass_raster.8.5.so: No such file or directory (needed by /usr/lib/gdalplugins/gdal_GRASS.so)
#23 3.344 ERROR 1: Error loading shared library libgrass_vector.8.5.so: No such file or directory (needed by /usr/lib/gdalplugins/ogr_GRASS.so)
#23 3.344 ERROR 1: Error loading shared library libgrass_vector.8.5.so: No such file or directory (needed by /usr/lib/gdalplugins/ogr_GRASS.so)

@nilason nilason added the backport to 8.4 PR needs to be backported to release branch 8.4 label Feb 14, 2025
@nilason nilason deleted the docker_again branch March 14, 2025 07:53
nilason added a commit to nilason/grass that referenced this pull request Nov 17, 2025
nilason added a commit to nilason/grass that referenced this pull request Nov 18, 2025
nilason added a commit to nilason/grass that referenced this pull request Nov 18, 2025
nilason added a commit that referenced this pull request Nov 18, 2025
@nilason nilason modified the milestones: 8.5.0, 8.4.2 Nov 18, 2025
@nilason nilason removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Docker related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants