Skip to content

Comments

docker: Fix git clone path in Dockerfile for gdal-grass#5111

Merged
echoix merged 1 commit intoOSGeo:mainfrom
echoix:cmake-docker-gdal-grass
Feb 14, 2025
Merged

docker: Fix git clone path in Dockerfile for gdal-grass#5111
echoix merged 1 commit intoOSGeo:mainfrom
echoix:cmake-docker-gdal-grass

Conversation

@echoix
Copy link
Member

@echoix echoix commented Feb 13, 2025

If my hypothesis in #5108 (comment) is right, this should solve the build failure

@echoix echoix requested a review from nilason February 13, 2025 22:24
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is it, was just about to push this too.
(I tested the git command before locally and adjusted there the path. Stayed so after copy-paste back.)

@nilason nilason added this to the 8.5.0 milestone Feb 13, 2025
@nilason nilason added the backport to 8.4 PR needs to be backported to release branch 8.4 label Feb 13, 2025
@echoix echoix enabled auto-merge (squash) February 13, 2025 22:31
@github-actions github-actions bot added the docker Docker related label Feb 13, 2025
@echoix echoix merged commit d3993e2 into OSGeo:main Feb 14, 2025
26 checks passed
@echoix echoix deleted the cmake-docker-gdal-grass branch February 14, 2025 00:21
@echoix
Copy link
Member Author

echoix commented Feb 14, 2025

@wenzeslaus
Copy link
Member

It seems to me we need to run Docker in PR.

@nilason
Copy link
Contributor

nilason commented Feb 14, 2025

It seems to me we need to run Docker in PR.

In general we still have too much total CI time. With little more than occasional activity, the CIs get bogged down quickly and prevents further work. Which is a shame.
Would it be possible to trigger a workflow based on changes on any Dockerfile (modified file by name)?

@echoix
Copy link
Member Author

echoix commented Feb 14, 2025

It seems to me we need to run Docker in PR.

In general we still have too much total CI time. With little more than occasional activity, the CIs get bogged down quickly and prevents further work. Which is a shame.

Would it be possible to trigger a workflow based on changes on any Dockerfile (modified file by name)?

Once the workflow itself is verified safe to run on PRs, then it would be possible to use a similar approach to the one used in additional checks, like for pre-commit. We could also add a workflow_dispatch trigger, that means we can manually launch a run.

@nilason
Copy link
Contributor

nilason commented Feb 14, 2025

workflow_dispatch would perhaps be the least complicated solution.

@nilason
Copy link
Contributor

nilason commented Feb 14, 2025

And that would also be available if there are other changes that are not in Dockerfile but potentially still affect.

@echoix
Copy link
Member Author

echoix commented Feb 14, 2025

workflow_dispatch would perhaps be the least complicated solution.

But, would be needed to run on the fork's branch, because I don't think we can select a branch to run on on a branch that comes from a forked repo (like all our PRs come from forks)

@echoix
Copy link
Member Author

echoix commented Feb 14, 2025

And that would also be available if there are other changes that are not in Dockerfile but potentially still affect.

For this, I only know that there's a way to do something that works with custom-purpose labels to control what to run/request what to run. But it's harder to setup, but afterwards it's kind of easy to use

@neteler neteler removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Docker related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants