Skip to content

Comments

docker: build gdal-grass with CMake#5106

Merged
wenzeslaus merged 1 commit intoOSGeo:mainfrom
nilason:docker_gdal-grass
Feb 13, 2025
Merged

docker: build gdal-grass with CMake#5106
wenzeslaus merged 1 commit intoOSGeo:mainfrom
nilason:docker_gdal-grass

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Feb 13, 2025

After gdal-grass' drop of Autotools support with
OSGeo/gdal-grass@fa4b045.

I can't test these changes, but it should be good. Either someone could test it manually, or we merge and see...

After gdal-grass' drop of Autotools support with
OSGeo/gdal-grass@fa4b045
@nilason nilason added this to the 8.5.0 milestone Feb 13, 2025
@github-actions github-actions bot added the docker Docker related label Feb 13, 2025
@neteler neteler added the backport to 8.4 PR needs to be backported to release branch 8.4 label Feb 13, 2025
@neteler
Copy link
Member

neteler commented Feb 13, 2025

Thanks! To make G84 happy as well we'll need to backport this PR once merged.

@wenzeslaus
Copy link
Member

Fixes #5107

@wenzeslaus
Copy link
Member

We need to have a representative the Docker build (e.g. the one from root dir Dockerfile) build for PRs for clarity. It may also be a good idea to not use latest version in the clone, but a release instead.

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the build is broken and the CI tests that only on main and we have already bunch of commits there failing with this error. Let's merge it.

@wenzeslaus wenzeslaus merged commit 1c1d01d into OSGeo:main Feb 13, 2025
27 checks passed
@nilason
Copy link
Contributor Author

nilason commented Feb 13, 2025

It may also be a good idea to not use latest version in the clone, but a release instead.

These changes should work for latest release too, if we were to change version.

@nilason
Copy link
Contributor Author

nilason commented Feb 13, 2025

Ahh, Alpine didn't install cmake. I'll fix that.

@nilason nilason deleted the docker_gdal-grass branch February 13, 2025 12:20
@neteler
Copy link
Member

neteler commented Feb 20, 2025

@nilason shall we keep the hardcoded-version workaround for G84 or shall anything from main be backported?

@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2025

@nilason shall we keep the hardcoded-version workaround for G84 or shall anything from main be backported?

I don't know. I never tested if gdal-grass driver actually worked before without hardcoded paths. But backporting that part wouldn't hurt either.

nilason added a commit to nilason/grass that referenced this pull request Nov 17, 2025
nilason added a commit to nilason/grass that referenced this pull request Nov 18, 2025
nilason added a commit to nilason/grass that referenced this pull request Nov 18, 2025
nilason added a commit that referenced this pull request Nov 18, 2025
@nilason nilason modified the milestones: 8.5.0, 8.4.2 Nov 18, 2025
@nilason nilason removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Docker related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants