doc: Redefine r.mapcalc build deps for color table thumbnails#5098
Merged
wenzeslaus merged 2 commits intoOSGeo:mainfrom Feb 13, 2025
Merged
doc: Redefine r.mapcalc build deps for color table thumbnails#5098wenzeslaus merged 2 commits intoOSGeo:mainfrom
wenzeslaus merged 2 commits intoOSGeo:mainfrom
Conversation
Member
Author
petrasovaa
approved these changes
Feb 12, 2025
Contributor
petrasovaa
left a comment
petrasovaa
left a comment
There was a problem hiding this comment.
Let's give this a try (depending on the CI results)
Contributor
|
See also #3038. |
Member
Author
Member
Author
|
The CI looks good but needs update to #5102 for stability. |
wenzeslaus
changed the title
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original dependency handling between r.color and r.mapcalc from fd7d0ec and 9e56f6c uses dependency on binaries and builds r.mapcalc ahead of time. The new build code explicitly declares the dependency between r.color and r.mapcalc subdir phony targets.
This works for me locally with (-j1, -j2, -j4, -j10, -j30):
This fixes the new issue which arose in #5048 with the Markdown documentation where r.colors build failed because r.mapcalc gave permission denied. I temporarily fixed the issue in #5048 by removing r.mapcalc from SUBDIRS. However, the change broke the recompilation with distclean not tested in CI). The new approach with explicit subdir phony target dependency avoids both issues.