r.sim: fix turning off parallelization with mask on#5037
Merged
petrasovaa merged 1 commit intoOSGeo:mainfrom Feb 4, 2025
Merged
r.sim: fix turning off parallelization with mask on#5037petrasovaa merged 1 commit intoOSGeo:mainfrom
petrasovaa merged 1 commit intoOSGeo:mainfrom
Conversation
petrasovaa
added
the
backport to 8.4
github-actions
bot
added
raster
echoix
approved these changes
Feb 3, 2025
wenzeslaus
approved these changes
Feb 4, 2025
petrasovaa
added a commit
that referenced
this pull request
Feb 4, 2025
Member
|
@petrasovaa After the backport to G8.4 there is a CI error (both in r.sim.sediment and r.sim.water):
The reason is that also #4402 needs to be backported. |
Contributor
|
#4402 changes libraster API, which probably is best to avoid for a patch release. |
Contributor
Author
|
Sorry for the mess, see #5052. |
neteler
removed
the
backport to 8.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mask test was in a wrong place, so it didn't turn off parallelization when mask was active.