Skip to content

Comments

Windows: Apply OSGeo4W patches for PostgreSQL (backport)#5005

Merged
neteler merged 1 commit intoOSGeo:releasebranch_8_4from
neteler:osgeo4w-postgres-patch_backport
Jan 29, 2025
Merged

Windows: Apply OSGeo4W patches for PostgreSQL (backport)#5005
neteler merged 1 commit intoOSGeo:releasebranch_8_4from
neteler:osgeo4w-postgres-patch_backport

Conversation

@neteler
Copy link
Member

@neteler neteler commented Jan 29, 2025

Backport of #4996 to G84 branch

Co-authored-by: @echoix

@neteler neteler added bug Something isn't working windows Microsoft Windows specific CI Continuous integration labels Jan 29, 2025
@neteler neteler added this to the 8.4.1 milestone Jan 29, 2025
@neteler neteler requested a review from echoix January 29, 2025 10:30
@neteler neteler self-assigned this Jan 29, 2025
@neteler neteler mentioned this pull request Jan 29, 2025
Merged
@echoix
Copy link
Member

echoix commented Jan 29, 2025

I know that for the grass (non grass-dev), the patches were different. Are we fine to place this change as-is?

@nilason
Copy link
Contributor

nilason commented Jan 29, 2025

I know that for the grass (non grass-dev), the patches were different. Are we fine to place this change as-is?

I would think so.

checking whether to use PostgreSQL... "yes"
checking for location of PostgreSQL includes... /c/OSGeo4W/include
checking for libpq-fe.h... yes
checking for location of PostgreSQL library... /d/a/grass/grass/mswindows/osgeo4w/lib
checking for PQsetdbLogin in -lpq... yes
checking for PQcmdTuples in -lpq... yes

...

  PostgreSQL support:         yes

@neteler neteler merged commit ec54064 into OSGeo:releasebranch_8_4 Jan 29, 2025
26 checks passed
@neteler neteler deleted the osgeo4w-postgres-patch_backport branch January 29, 2025 15:23
@neteler neteler changed the title Windows: Apply OSGeo4W patches for Postgres (backport) Windows: Apply OSGeo4W patches for PostgreSQL (backport) Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilason nilason nilason approved these changes

@echoix echoix Awaiting requested review from echoix

Assignees

@neteler neteler

Labels

bug Something isn't working CI Continuous integration windows Microsoft Windows specific

Projects

None yet

Milestone

8.4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@neteler @echoix @nilason