Windows: Apply OSGeo4W patches for PostgreSQL#4996
Merged
echoix merged 4 commits intoOSGeo:mainfrom Jan 28, 2025
Merged
Conversation
Member
Author
|
Not enough :( |
Member
Author
|
Ok, I don't understand why the path I set isn't shown in the configure failure, I changed that line... |
echoix
force-pushed
the
osgeo4w-postgre-patch
branch
from
8d7971b to
c7b1427
Compare
…_osgeo4w.sh like package.sh
Member
Author
|
It seems enough to copy the lib like in package.sh (used in osgeo4w), the build passed the configure stage. It is our highest priority PR for now, it is blocking all other work |
wenzeslaus
approved these changes
Jan 28, 2025
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
While I don't understand the nuances of patching the files downstream and having two files here, this looks good to me. Clearly, the change is needed here, too, not only downstream.
Member
|
l'll try to backport this to G84, see #5005 |
neteler
added a commit
that referenced
this pull request
Jan 29, 2025
Backport of #4996 to G84 branch
neteler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #4990
(Hopefully)
I quickly applied the patch that changed downstream. I didn’t test it in CI yet, I’m just launching it here quickly.
It seems like Postgres is compiled with a different compiler now, so removing and copying a lib seems necessary.
I also launched echoix#351