r.sim.water: build topology for vector output#4969
Merged
echoix merged 1 commit intoOSGeo:mainfrom Jan 22, 2025
Merged
Conversation
metzm
added
enhancement
Member
|
FYI |
neteler
approved these changes
Jan 21, 2025
Member
neteler
left a comment
neteler
left a comment
There was a problem hiding this comment.
Looks good to me as it fixes a compatibility issue to other software.
1 task
neteler
pushed a commit
that referenced
this pull request
Jan 22, 2025
neteler
removed
the
backport to 8.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topology was not built for the vector output
walkers_output. This is within GRASS not a problem, but the QGIS interface fails because a vector without topology can not be exported withv.out.ogr, consequently QGIS complains about a missing output. With this PR, topology is built for the vector output which should not have any effects otherwise because it is only a points vector with simple topology.