i.fft: added test file for i.fft module#4931
Merged
petrasovaa merged 9 commits intoOSGeo:mainfrom Jan 16, 2025
jayneel-shah18:i.fft_tests
Merged
i.fft: added test file for i.fft module#4931petrasovaa merged 9 commits intoOSGeo:mainfrom jayneel-shah18:i.fft_tests
petrasovaa merged 9 commits intoOSGeo:mainfrom
jayneel-shah18:i.fft_tests
Conversation
Member
|
Looks great! |
echoix
previously approved these changes
Jan 10, 2025
Member
echoix
left a comment
There was a problem hiding this comment.
Does someone else have something to add?
Member
|
I think @petrasovaa had some comments, but I don't know if she can get to it. |
petrasovaa
requested changes
Jan 14, 2025
petrasovaa
approved these changes
Jan 15, 2025
Contributor
|
Great, thanks for addressing my comments! |
pesekon2
added a commit
that referenced
this pull request
Jan 16, 2025
We don't have `trunk` anymore since we departed from SVN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a comprehensive suite of tests for the
i.fftGRASS GIS module. These tests cover a wide range of scenarios, including basic functionality, advanced properties like energy conservation and linearity, and edge cases such as all-zero and all-one rasters. Performance for larger datasets is also assessed.Key updates in this PR include:
i.ifft.Test Case Additions:
Basic Functionality:
i.fftproduces real and imaginary output rasters.Advanced Properties:
i.ifftfor accurate reconstruction of the original raster.Edge Cases:
Performance: