Skip to content

Comments

r.resamp.filter: update manual#4856

Merged
metzm merged 3 commits intoOSGeo:mainfrom
metzm:r.resamp.filter_manual
Dec 18, 2024
Merged

r.resamp.filter: update manual#4856
metzm merged 3 commits intoOSGeo:mainfrom
metzm:r.resamp.filter_manual

Conversation

@metzm
Copy link
Contributor

@metzm metzm commented Dec 17, 2024

Update the manual according to #2569

Fixes #2569

@metzm metzm added raster Related to raster data processing HTML Related code is in HTML labels Dec 17, 2024
@neteler neteler changed the title r.resamo.filter: update manual r.resamp.filter: update manual Dec 17, 2024
@neteler neteler added the backport to 8.4 PR needs to be backported to release branch 8.4 label Dec 17, 2024
@metzm
Copy link
Contributor Author

metzm commented Dec 17, 2024

Isn't it overkill and an unnecessary waste of resources that all (also build) tests are started when a single manual is updated?

@neteler
Copy link
Member

neteler commented Dec 17, 2024

Isn't it overkill and an unnecessary waste of resources that all (also build) tests are started when a single manual is updated?

That was also my thought once:

[Feat] CI: add support for [skip ci] #2174

@metzm
Copy link
Contributor Author

metzm commented Dec 18, 2024

Isn't it overkill and an unnecessary waste of resources that all (also build) tests are started when a single manual is updated?

That was also my thought once:

[Feat] CI: add support for [skip ci] #2174

Didn't know this, very helpful for cases like this: https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/ So "the contributor needs to carefully decide" it seems.

@echoix
Copy link
Member

echoix commented Dec 18, 2024

Isn't it overkill and an unnecessary waste of resources that all (also build) tests are started when a single manual is updated?

That was also my thought once:

[Feat] CI: add support for [skip ci] #2174

Didn't know this, very helpful for cases like this: https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/ So "the contributor needs to carefully decide" it seems.

Also, the final commit shouldn't be skipped, as some checks are required, and won't run. Unless the one merging has super-powers and can force it, but them he/she needs to make sure the squashed-merged commit isn't skipped so the CI on merge still runs

@metzm
Copy link
Contributor Author

metzm commented Dec 18, 2024

Didn't know this, very helpful for cases like this: https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/ So "the contributor needs to carefully decide" it seems.

Also, the final commit shouldn't be skipped, as some checks are required, and won't run. Unless the one merging has super-powers and can force it, but them he/she needs to make sure the squashed-merged commit isn't skipped so the CI on merge still runs

[skip ci] does not work as expected, I don't see a need to run the required build checks for changes in a manual. HTML syntax checking should be sufficient in this case? Maybe the issue #2174 should be re-opened?

@echoix
Copy link
Member

echoix commented Dec 18, 2024

[skip ci] does not work as expected, I don't see a need to run the required build checks for changes in a manual. HTML syntax checking should be sufficient in this case? Maybe the issue #2174 should be re-opened?

If you search in some comments somewhere, I think it was with @wenzeslaus, we agreed that it saved us in some cases, even when it is just docs. It's way more complicated to get it right by not checking the same as any PR. And the [skip ci] did exactly what it said it did, it didn't run any CI as wished, but it's not always desirable.

@metzm metzm merged commit d12eea5 into OSGeo:main Dec 18, 2024
@metzm metzm deleted the r.resamp.filter_manual branch December 18, 2024 20:07
@github-actions github-actions bot added this to the 8.5.0 milestone Dec 18, 2024
metzm added a commit that referenced this pull request Dec 18, 2024
* r.resamo.filter: update manual
@neteler neteler removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Dec 18, 2024
@neteler neteler modified the milestones: 8.5.0, 8.4.1 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs HTML Related code is in HTML module raster Related to raster data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] Provide better explanation for radius parameter for r.resamp.filter

3 participants