Conversation
|
Isn't it overkill and an unnecessary waste of resources that all (also build) tests are started when a single manual is updated? |
That was also my thought once: [Feat] CI: add support for [skip ci] #2174 |
Didn't know this, very helpful for cases like this: https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/ So "the contributor needs to carefully decide" it seems. |
Also, the final commit shouldn't be skipped, as some checks are required, and won't run. Unless the one merging has super-powers and can force it, but them he/she needs to make sure the squashed-merged commit isn't skipped so the CI on merge still runs |
[skip ci] does not work as expected, I don't see a need to run the required build checks for changes in a manual. HTML syntax checking should be sufficient in this case? Maybe the issue #2174 should be re-opened? |
If you search in some comments somewhere, I think it was with @wenzeslaus, we agreed that it saved us in some cases, even when it is just docs. It's way more complicated to get it right by not checking the same as any PR. And the [skip ci] did exactly what it said it did, it didn't run any CI as wished, but it's not always desirable. |
* r.resamo.filter: update manual
Update the manual according to #2569
Fixes #2569