win: Trim trailing whitespace in R batch files#4790
Conversation
|
README.license may be used in packaging, just make sure before… |
|
Ok.. if there's something, it would be closer to the expected line ending to be stored through git (CRLF not being what we would want in git) |
|
Keep in mind that these files are externally svn checked out from the mentioned source code repository. Is it important to change line endings? I have no chance to test it locally. Sometimes different ms Windows versions are differently sensitive to such changes. |
Not SVN anymore, but yes, I'm aware of the repo and plan to upstream the changes too.
It doesn't change them yet here. (In 3 PRs, if all prerequisites are merged). And when it will, it will be to enforce having .bat stored into git as CRLF exactly for that reason, where .bat files are expected to be that way. People checking out files even with core crlf set to lf will still have the .bat files as CRLF (according to the settings in the .gitattributes file). Even a older Windows 10 notepad has no problems reading a text file with LF, assuming packaging was done wrong for extra files. So this PR in particular is really conservative in my opinion, and there's no reason to discuss too much here, there will be other PRs that are better candidates with actual changes. (Thus why taking unimportant changes needing no review out of another PR to prevent stalling the review of the next one). Other PRs that I considered a preliminary work for getting editorconfig set up for the repo were started in last March, but only one got merged this week. I was still waiting until recently, when the inconveniences of not having editorconfig were starting to be bigger and caused problems, to which I started back the efforts, even if it means having to rebase and solve conflicts. Grass-addons and grass-tutorial will need it too, and I would like it to have similar if not identical .editorconfig files, and a similar CI/precommit config to be easier to maintain. |
|
Can someone with enough permissions proxy the approval? |
This is one of the preparatory PRs for introducing and enforcing editorconfig-checker.
Starting with only applying whitespace trim on R batch files, without any other mixed changes (no line ending LF/CRLF here, yet) (Except for mswindows/external/README.license that isn't rbatch, but our file, this one is changed like a markdown to LF, as it is "our" file)