db/MySQL: fix HTML manual nested <ul></ul> element position#4778
Merged
tmszi merged 2 commits intoOSGeo:mainfrom Nov 28, 2024
Merged
db/MySQL: fix HTML manual nested <ul></ul> element position#4778tmszi merged 2 commits intoOSGeo:mainfrom
<ul></ul> element position#4778tmszi merged 2 commits intoOSGeo:mainfrom
Conversation
Fix `HTMLParser()` class instance find nested `<ul>` end element `</ul>`
error during compilation GRASS GIS source code:
```
Error (IndexError('pop from empty list'))
```
Problematic is nested `<ul></ul>` HTML element inside parent `<ul></ul>`
element:
```
<ul>
<li></li>
<li></li>
<ul>
<li></li>
<li></li>
<li></li>
</ul>
</ul>
```
Expected nested `<ul></ul>` HTML element inside parent `<ul></ul>` is
nested position inside `<li></li>` element.
```
<ul>
<li></li>
<li>
<ul>
<li></li>
<li></li>
<li></li>
</ul>
</li>
</ul>
```
tmszi
added
bug
echoix
previously approved these changes
Nov 28, 2024
echoix
approved these changes
Nov 28, 2024
tmszi
added a commit
that referenced
this pull request
Nov 28, 2024
* db/MySQL: fix HTML manual nested `<ul></ul>` element position
Fix `HTMLParser()` class instance find nested `<ul>` end element `</ul>`
error during compilation GRASS GIS source code:
```
Error (IndexError('pop from empty list'))
```
Problematic is nested `<ul></ul>` HTML element inside parent `<ul></ul>`
element:
```
<ul>
<li></li>
<li></li>
<ul>
<li></li>
<li></li>
<li></li>
</ul>
</ul>
```
Expected nested `<ul></ul>` HTML element inside parent `<ul></ul>` is
nested position inside `<li></li>` element.
```
<ul>
<li></li>
<li>
<ul>
<li></li>
<li></li>
<li></li>
</ul>
</li>
</ul>
```
* Fix typo of key word
neteler
removed
the
backport to 8.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
HTMLParser()class instance find nested<ul>end element</ul>error during compilation GRASS GIS source code:Problematic is nested
<ul></ul>HTML element inside parent<ul></ul>element:Expected nested
<ul></ul>HTML element inside parent<ul></ul>is nested position inside<li></li>element.Fixes #4777.