r.sim.water: add info to manual, add info about progress#4662
r.sim.water: add info to manual, add info about progress#4662neteler merged 13 commits intoOSGeo:mainfrom
Conversation
metzm
added
manual
Co-authored-by: Anna Petrasova <[email protected]>
Co-authored-by: Anna Petrasova <[email protected]>
|
This sentence may be confusing "The model is for shallow water flow, where "shallow" is defined by hmax"- Perhaps the paragraph could start with "the model tries to keep water "shallow" with maximum shallow water depth defined by hmax value (default is 0.3m). If hmax is reached then .... here goes the text that explains the increase in diffusion rate and related parameters .... The rest of the text that explains when these parameters may need to be adjusted sounds good to me. |
|
This new description comes from #4475, maybe @petrasovaa can clarify? I am not sure if the model tries to keep water "shallow". After |
neteler
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
neteler
changed the title
neteler
left a comment
neteler
left a comment
There was a problem hiding this comment.
Locally tested, looks good to me.
|
May this be merged, @petrasovaa ? |
neteler
left a comment
neteler
left a comment
There was a problem hiding this comment.
This is an important documentation fix, thanks.
neteler
left a comment
neteler
left a comment
There was a problem hiding this comment.
This is an important documentation fix, thanks.
neteler
added
the
backport to 8.4
@petrasovaa since this documentation improvement is important, can we move on and merge this PR? |
* `r.sim.water` is a module with a number of important but not well documented parameters. This PR adds more information about some parameters to the manual. * It takes quite some time to run a simulation, another message is added to the progress of the simulation. This PR tries to add info requested in #4475 to the manual Co-authored-by: Anna Petrasova <[email protected]> Co-authored-by: Markus Neteler <[email protected]>
neteler
removed
the
backport to 8.4
4 participants
r.sim.wateris a module with a number of important but not well documented parameters. This PR adds more information about some parameters to the manual.This PR tries to add info requested in #4475 to the manual