Merged
Conversation
petrasovaa
added
the
backport to 8.4
echoix
approved these changes
Nov 5, 2024
Member
echoix
left a comment
echoix
left a comment
There was a problem hiding this comment.
New code seems fine, but I don't understand why vars() was needed before
Contributor
Author
Not sure either |
wenzeslaus
approved these changes
Nov 5, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
I think the idea was to create local variables dynamically. Dictionary is a better solution for dynamically managing multiple key-value pairs.
Merged
neteler
pushed a commit
that referenced
this pull request
Nov 6, 2024
neteler
removed
the
backport to 8.4
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4651. vars() acts like locals() and there have been some changes:
https://docs.python.org/3/whatsnew/3.13.html#whatsnew313-locals-semantics