Skip to content

Comments

style: Sort package lists, configure options, and other various sortable files#4563

Merged
echoix merged 17 commits intoOSGeo:mainfrom
echoix:sort-configure-packages
Nov 2, 2024
Merged

style: Sort package lists, configure options, and other various sortable files#4563
echoix merged 17 commits intoOSGeo:mainfrom
echoix:sort-configure-packages

Conversation

@echoix
Copy link
Member

@echoix echoix commented Oct 21, 2024

Follow up from last month's #4373.

This PR sorts sortable parts of many remaining files. Build scripts, package lists, file lists, contributors lists, etc.
I made some searches on what looked like configure flags, and packages too.

About the only thing that wasn't sorted was everything in Makefiles, like directory lists or other lists in Makefiles, and the mingw64 packages in the osgeo4w.yml workflow, as the packages weren't placed in a line-delimited list yet

@echoix echoix requested a review from neteler October 21, 2024 01:27
@github-actions github-actions bot added windows Microsoft Windows specific macOS macOS specific linux Linux specific docker Docker related CI Continuous integration docs labels Oct 21, 2024
@neteler
Copy link
Member

neteler commented Oct 24, 2024

Thanks for your efforts.

We have a number of CSV files, perhaps some could be merged? Their origin is from CVS/SVN times with a different than GitHub write access model which is no longer in place:

  • contributors.csv
  • contributors_extra.csv
  • translators.csv
  • utils/git_author_github_name.csv
  • utils/svn_name_git_author.csv
  • utils/svn_name_github_name.csv

In case of structural changes (e.g., merging selectively) also a GUI change would be needed:

wxpython/gui_core/ghelp.py

            contribfile = os.path.join(os.getenv("GISBASE"), "contributors_extra.csv")
            contribfile = os.path.join(os.getenv("GISBASE"), "contributors.csv")
        translatorsfile = os.path.join(os.getenv("GISBASE"), "translators.csv")
                label=_("%s file missing") % "translators.csv",

However, maybe better done in a separate PR.

@echoix
Copy link
Member Author

echoix commented Oct 26, 2024

Thanks for your efforts.

We have a number of CSV files, perhaps some could be merged? Their origin is from CVS/SVN times with a different than GitHub write access model which is no longer in place:

  • contributors.csv
  • contributors_extra.csv
  • translators.csv
  • utils/git_author_github_name.csv
  • utils/svn_name_git_author.csv
  • utils/svn_name_github_name.csv

In case of structural changes (e.g., merging selectively) also a GUI change would be needed:

wxpython/gui_core/ghelp.py

            contribfile = os.path.join(os.getenv("GISBASE"), "contributors_extra.csv")
            contribfile = os.path.join(os.getenv("GISBASE"), "contributors.csv")
        translatorsfile = os.path.join(os.getenv("GISBASE"), "translators.csv")
                label=_("%s file missing") % "translators.csv",

However, maybe better done in a separate PR.

I made a separate issue for it #4599, as indeed, it is kind of a different topic than this PR.

@neteler neteler added this to the 8.5.0 milestone Oct 26, 2024
@echoix echoix requested a review from neteler November 2, 2024 12:54
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@echoix echoix merged commit e37730b into OSGeo:main Nov 2, 2024
@echoix echoix deleted the sort-configure-packages branch November 2, 2024 15:31
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Nov 11, 2024
…ble files (OSGeo#4563)

* style: Sort packages in Vagrantfile

* style: Sort configure flags in package.nix

* style: Sort .gunittest.cfg

* style: Sort Travis build files

* style: Sort python optional_requirements.txt

* style: Sort configure flags in GitHub workflows

* style: Sort packages and configure flags for binder

* style: Sort packages, configure flags, cmake flags and wget downloads in Dockerfiles

* style: Sort configure flags in Vagrant script

* style: Sort svn author name files with linux sort command

* style: Sort contributors.csv and contributors_extra.csv

* style: Sort rpm package spec

* style: Sort packages and configure flags in mswindows build scripts

* style: Sort macosx build script Readme

* style: Sort singularity file

* Apply changes from https://src.fedoraproject.org/rpms/grass/blob/rawhide/f/grass.spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration docker Docker related docs linux Linux specific macOS macOS specific windows Microsoft Windows specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants