docker: Sort package lists and configure options in Dockerfiles#4373
docker: Sort package lists and configure options in Dockerfiles#4373echoix merged 4 commits intoOSGeo:mainfrom
Conversation
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
I check the overall structure and sample of packages here and there and I don't see any issue with this.
|
Let's wait a day or so, to let Europeans have the chance to look |
|
Would it make sense, while at it, to also sort:
? |
|
What are those already? Is it related to docker? To do in the same PR or another? |
|
Vagrant: https://grasswiki.osgeo.org/wiki/Vagrant, added by @landam Singularity is for HPC environments, added by @lucadelu If here or elsewhere, I cannot judge. |
|
Ok, I took a quick look at it, and I'll do another PR for it, that would also do other build script that has the configure calls. So since it isn't docker related anymore, let's just start with this one that is ready to go. |
echoix
changed the title
- Backport for ubuntu_wxgui of "CI(deps): Update ubuntu Docker tag to v24 for ubuntu_wxgui Dockerfile (#6510)"; commit a782b7a - Backport for ubuntu_wxgui of "chore: Rename "GRASS GIS" to "GRASS" at top level, manual generation, Dockerfiles, scripts (#6162)"; commit b7a14bd - Backport for ubuntu_wxgui of "docker: fix various syntax warnings (#5481)"; commit 15731bc - Backport for ubuntu_wxgui of "docker: Sort package lists and configure options in Dockerfiles (#4373)"; commit 8c671ca Co-authored-by: Edouard Choinière <[email protected]> Co-authored-by: Markus Neteler <[email protected]>
3 participants
Package lists were unsorted, and I got tricked when adding liblapacke-dev and sorting the list thinking it was sorted (almost but not). Being unsorted makes finding a package harder. To prove this point,
zlib1g-devwas listed twice in the same list because it was unsorted.I simply used the sort lines feature of my IDE, VSCode, that is case-sensitive.