contributing: update style guide for C#4312
Merged
petrasovaa merged 2 commits intoOSGeo:mainfrom Sep 12, 2024
Merged
Conversation
nilason
reviewed
Sep 12, 2024
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Looks good to me, some minor notes only.
The CI runners will complain with absent void, so I believe there's no need for that info specifically.
Perhaps you can bump the note on ClangFormat version to:
(currently with version 18+), while updating the file.
nilason
approved these changes
Sep 12, 2024
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Great! Always difficult to draw the line on what to include here and still keep it short, if something comes up we can always update.
neteler
pushed a commit
that referenced
this pull request
Sep 12, 2024
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds relevant info from https://trac.osgeo.org/grass/wiki/Submitting/C as mentioned here. I left out some subsections from it, because I was not sure whether they are relevant, for example note about void functions.
I also added missing info about the python addon template and header.