ps.map: Fix copy into fixed size buffer issue in do_scalebar.c file#4307
Merged
nilason merged 7 commits intoOSGeo:mainfrom Sep 12, 2024
Merged
ps.map: Fix copy into fixed size buffer issue in do_scalebar.c file#4307nilason merged 7 commits intoOSGeo:mainfrom
nilason merged 7 commits intoOSGeo:mainfrom
Conversation
added 2 commits
September 11, 2024 19:12
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nilason
requested changes
Sep 12, 2024
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Besides the inline comment, there is only one minor suggestion:
You have, in this case correctly decided, to silence most of the return values with void, I think you can do the same with the remaining one.
The value of
Line 66 in 5719ba6
is guaranteed to fit into a buffer of size 50.
added 2 commits
September 12, 2024 16:09
Contributor
Author
Done |
nilason
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves a buffer overflow issue detected by Coverity Scan (CID 1208259).
strcpy is replaced with G_strlcpy