r.in.gdal/r.external: add basic support for GDALs GDT_Int8#4256
r.in.gdal/r.external: add basic support for GDALs GDT_Int8#4256ninsbl merged 13 commits intoOSGeo:mainfrom
Conversation
|
It compiles fine on Fedora 39 with GDAL 3.7.3. CI: There is an issue with this approach on systems with older GDAL: I am afraid that only a GDAL version check might work, like:
or by combining in a test (see
and
|
Better use |
|
Stefan, you should also add |
|
Thanks for your approval @nilason . I had to add a switch to skip the test for systems with GDAL < 3.7 (like Ubuntu 22.04, where tests failed). That commit dismissed your review, it would be great if you could re-approve... |
* add support for Int8 from GDAL >= 3.7 * add int8 test (skiped if GDAL < 3.7)
* add support for Int8 from GDAL >= 3.7 * add int8 test (skiped if GDAL < 3.7)
* add support for Int8 from GDAL >= 3.7 * add int8 test (skiped if GDAL < 3.7)
* add support for Int8 from GDAL >= 3.7 * add int8 test (skiped if GDAL < 3.7)
|
Should this be backported? |
* add support for Int8 from GDAL >= 3.7 * add int8 test (skiped if GDAL < 3.7)
|
Backported to 8.4 with c4b2304. |
This PR adds basic support for importing GDT_Int8 datatype via GDAL.
I am no C-programmer, so I would be happy if a knowledgeable person could look into this. I am especially unsure about the #ifndef part (note that 14 is the constant representing GDT_Int8).
Addresses #4230