t.rast.to.vect: Fix passing column parameter to r.to.vect, fix flake8 F841#4206
t.rast.to.vect: Fix passing column parameter to r.to.vect, fix flake8 F841#4206echoix merged 4 commits intoOSGeo:mainfrom
Conversation
"values" is a reserved sqlite keyword so when you fixed the tool, the specified column "values" started to be used, hence the error. Given there is a default specified, I would simply remove the column parameter from the test.
I would keep the call, but remove the return value, the check function should throw an error. |
|
Should there be an update in the .flake8 file as well? |
This is a manual backport to 8.4 of #4206 to include only the fix part.
…n /temporal/t.rast.to.vect (OSGeo#4206)
I think the "column" parameter needs to be added to the "r.to.vect" module call, but the test failed after adding it with the error below.
The test passed after I changed the column values in test_to_vect.py to "value". But I'm unsure about modifying unittest code, so I need some advice.
It is also possible to remove line 166 theoretically, but I didn't do so since Flake8 didn't complain about F841. Line 166 returns None or an object, so it could be used to determine whether the process is continuing or terminating.
If you could provide me with some insight on this, I would greatly appreciate it.