g.download.project: rename g.download.location#4187
Conversation
github-actions
bot
added
CI
echoix
left a comment
echoix
left a comment
There was a problem hiding this comment.
Looks good, assuming that the old contents of g.download.location were copied to g.download.project without hidden changes. The some docstrings could be changed later (more reviewable diff) to change location->project when needed.
The old g.download.location calls the new g.download.project, looks fine.
Html docs are also updated.
|
Please merge #4155 first. |
|
Is #4155 almost ready, or ready? |
|
@petrasovaa there is a conflict, but the change(s) from #4155 might need to be applied to a different file. It needs more than what the web interface offers to do it right. |
petrasovaa
force-pushed
the
g.download.project
branch
from
04071df to
79db0bc
Compare
echoix
left a comment
echoix
left a comment
There was a problem hiding this comment.
Let's go with this. Thanks Anna!
|
@petrasovaa Do you want this to be backported to G8.4? For now it landed in G8.5. |
|
Right, done. |
3 participants
To continue with the location to project renaming, this PR is renaming g.download.location to g.download.project. For backwards compatibility I left g.download.location that calls g.download.project.
My suggestion is to add a warning to g.download.location in/after 8.5 and remove it completely for GRASS 9.