g.download.location: Print target path in error message#4155
Merged
echoix merged 4 commits intoOSGeo:mainfrom Aug 19, 2024
neteler:g_download_location_target_path
Merged
g.download.location: Print target path in error message#4155echoix merged 4 commits intoOSGeo:mainfrom neteler:g_download_location_target_path
echoix merged 4 commits intoOSGeo:mainfrom
neteler:g_download_location_target_path
Conversation
To be less obscure (seen in addons CI log):
```
ERROR: Location named <nc_spm_full_v2alpha2> already exists, download
canceled
```
where actually the existing Location is, this PR improves the error message:
```
g.download.location url=https://grass.osgeo.org/sampledata/north_carolina/nc_spm_full_v2alpha2.tar.gz path=$HOME
ERROR: Location named <nc_spm_full_v2alpha2> already exists in
</home/mneteler/nc_spm_full_v2alpha2>, download canceled
```
neteler
added
enhancement
Member
Author
|
(I came across this issue while locally testing https://github.com/OSGeo/grass-addons/blob/grass8/.github/workflows/test.sh) |
wenzeslaus
requested changes
Aug 9, 2024
wenzeslaus
changed the title
Co-authored-by: Vaclav Petras <[email protected]>
Member
|
Slightly related, but the same problem: I read the docs of g.download.location the other day, and it seems there isn't a way to either download if missing, or to not fail if the same dataset already exists. If it was possible, it would allow for example to use the script test_thorough.sh in the CI, and run it locally multiple times, instead of being able to run it once, then to adapt and only copy the second invocation. At least this PR improves by showing more info as to where the data already exists. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
veroandreo
reviewed
Aug 14, 2024
Contributor
veroandreo
left a comment
veroandreo
left a comment
There was a problem hiding this comment.
NC sample datasets are projects. I'd avoid calling them databases since usually the grassdata folder (a folder of projects) is called database. Also included a suggestion for @wenzeslaus' comment.
Co-authored-by: Veronica Andreo <[email protected]>
wenzeslaus
approved these changes
Aug 19, 2024
petrasovaa
pushed a commit
that referenced
this pull request
Aug 22, 2024
* g.download.location: print target path in error message
To be less obscure in case the target location directory already exists:
```
ERROR: Location named <nc_spm_full_v2alpha2> already exists, download
canceled
```
this PR improves the error message to include the path:
```
g.download.location url=https://grass.osgeo.org/sampledata/north_carolina/nc_spm_full_v2alpha2.tar.gz path=$HOME
ERROR: Location named <nc_spm_full_v2alpha2> already exists in
</home/mneteler/nc_spm_full_v2alpha2>, download canceled
```
This is esp. relevant for scripted usage when the command isn't invoked directly by the user.
In addition, section of **EXAMPLES** added.
* fix message format
Co-authored-by: Vaclav Petras <[email protected]>
* database -> project
Co-authored-by: Veronica Andreo <[email protected]>
---------
Co-authored-by: Vaclav Petras <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
landam
pushed a commit
to landam/grass
that referenced
this pull request
Aug 22, 2024
* g.download.location: print target path in error message
To be less obscure in case the target location directory already exists:
```
ERROR: Location named <nc_spm_full_v2alpha2> already exists, download
canceled
```
this PR improves the error message to include the path:
```
g.download.location url=https://grass.osgeo.org/sampledata/north_carolina/nc_spm_full_v2alpha2.tar.gz path=$HOME
ERROR: Location named <nc_spm_full_v2alpha2> already exists in
</home/mneteler/nc_spm_full_v2alpha2>, download canceled
```
This is esp. relevant for scripted usage when the command isn't invoked directly by the user.
In addition, section of **EXAMPLES** added.
* fix message format
Co-authored-by: Vaclav Petras <[email protected]>
* database -> project
Co-authored-by: Veronica Andreo <[email protected]>
---------
Co-authored-by: Vaclav Petras <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
* g.download.location: print target path in error message
To be less obscure in case the target location directory already exists:
```
ERROR: Location named <nc_spm_full_v2alpha2> already exists, download
canceled
```
this PR improves the error message to include the path:
```
g.download.location url=https://grass.osgeo.org/sampledata/north_carolina/nc_spm_full_v2alpha2.tar.gz path=$HOME
ERROR: Location named <nc_spm_full_v2alpha2> already exists in
</home/mneteler/nc_spm_full_v2alpha2>, download canceled
```
This is esp. relevant for scripted usage when the command isn't invoked directly by the user.
In addition, section of **EXAMPLES** added.
* fix message format
Co-authored-by: Vaclav Petras <[email protected]>
* database -> project
Co-authored-by: Veronica Andreo <[email protected]>
---------
Co-authored-by: Vaclav Petras <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be less obscure in case the target location directory already exists:
this PR improves the error message to include the path:
This is esp. relevant for scripted usage when the command isn't invoked directly by the user.
In addition, section of EXAMPLES added.