lib/vector: new functions for setting trim of GEOS WKT output#4123
Merged
nilason merged 2 commits intoOSGeo:mainfrom Aug 2, 2024
Merged
lib/vector: new functions for setting trim of GEOS WKT output#4123nilason merged 2 commits intoOSGeo:mainfrom
nilason merged 2 commits intoOSGeo:mainfrom
Conversation
GEOS 3.12 switched the default setting of the trim option to true. To enable consistent behaviour to Vect_read_area_to_wkt() and Vect_line_to_wkt() across GEOS versions, they now call new 2nd generation functions, which set this trim option explicitly to false.
github-actions
bot
added
vector
echoix
previously approved these changes
Aug 1, 2024
echoix
reviewed
Aug 1, 2024
echoix
approved these changes
Aug 2, 2024
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
…4123) GEOS 3.12 switched the default setting of the trim option to true. To enable consistent behaviour to Vect_read_area_to_wkt() and Vect_line_to_wkt() across GEOS versions, they now call new 2nd generation functions, which set this trim option explicitly to false.
Member
|
Shall I backport it, @nilason ? |
Contributor
Author
Please, do. |
neteler
pushed a commit
that referenced
this pull request
Sep 20, 2024
GEOS 3.12 switched the default setting of the trim option to true. To enable consistent behaviour to Vect_read_area_to_wkt() and Vect_line_to_wkt() across GEOS versions, they now call new 2nd generation functions, which set this trim option explicitly to false.
neteler
removed
the
backport to 8.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOS 3.12 switched the default setting of the trim option to true. To enable consistent behaviour to
Vect_read_area_to_wkt()andVect_line_to_wkt()across GEOS versions, they now call new 2nd generation functions, which set this trim option explicitly to false.Closes: #4117 #4118